-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pad with a mix of bytes and longs #147
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Checking locally with JOL internals on my M1 the B2 fields are laid out at the exact same offset (280), only discernible difference is that
Before:
Note: while using hexadecimal has a size benefit, I just thought it made it easier to check that the generated code is correct since everything aligns when doing 16 vars per line, e.g.:
|
Using a mix of bytes and longs we should get the gap-filling effect described in https://shipilev.net/jvm/objects-inside-out/#_observation_hierarchy_tower_padding_trick_collapse_in_jdk_15 while reducing size of generated code by roughly 20%:
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/147/head:pull/147
$ git checkout pull/147
Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.org/jmh.git pull/147/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 147
View PR using the GUI difftool:
$ git pr show -t 147
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/147.diff