-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] These changes allow to build a minimal hotspot for iOS #30
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back jvos! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@@ -161,12 +161,17 @@ ifeq ($(call isTargetOs, linux), true) | |||
JVM_LDFLAGS += -Wl,-version-script=$(HOTSPOT_VERSION_SCRIPT) | |||
endif | |||
|
|||
ifeq ($(call isTargetOs, ios), true) | |||
LIB_TYPE := STATIC_LIBRARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going forward, this will not be needed; running the proper make target will take care of making it static automatically.
@johanvos This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep alive |
@johanvos this pull request can not be integrated into git checkout ios-minimal-vm
git fetch https://git.openjdk.org/mobile.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
This WIP PR allows to build the hotspot minimal variant for iOS.
There is an interesting PR for upstream openjdk/jdk which contains useful parts (e.g. a function lookup): openjdk/jdk#20837
I took the liberty to use parts of that PR in this PR. If the upstream PR got merged, it should be relatively easy to merge this in openjdk/mobile.
To build the minimal hotspot for iOS, use a configuration like this one:
Then build it:
Progress
Warnings
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/mobile.git pull/30/head:pull/30
$ git checkout pull/30
Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/mobile.git pull/30/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30
View PR using the GUI difftool:
$ git pr show -t 30
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/mobile/pull/30.diff