Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295110: RISC-V: Mark out relocations as incompressible #45

Open
wants to merge 4 commits into
base: riscv-port
Choose a base branch
from

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Dec 12, 2024

Hi,
Please help review this backport to riscv-port-jdk11u.
This backport contains multiple issues:

The original patch cannot be directly applied because of riscv-port-jdk11u do not have ZGC andsome minor conflict resolution.
Another conflict is that we do not have the refactoring 8295270: RISC-V: Clean up and refactoring for assembler functions on 11u.

It's also worth mentioning that there are some changes to the 8295110 implementation because jdk11u uses gnu++98 which cannot use lambda.

Testing:

  • Tier1 passed without new failure on lp4a (release).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8295110: RISC-V: Mark out relocations as incompressible (Enhancement - P4)
  • JDK-8305112: RISC-V: Typo fix for RVC description (Enhancement - P5)
  • JDK-8295396: RISC-V: Cleanup useless CompressibleRegions (Enhancement - P4)
  • JDK-8305512: RISC-V: Enable RVC extension by default on supported hardware (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/45/head:pull/45
$ git checkout pull/45

Update a local copy of the PR:
$ git checkout pull/45
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/45/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 45

View PR using the GUI difftool:
$ git pr show -t 45

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/45.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9005af3b90fbd3607aeb83efe1c4a6ffa5d104f0 8295110: RISC-V: Mark out relocations as incompressible Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 12, 2024
@DingliZhang
Copy link
Member Author

/issue 8305112 8295396 8305512

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@DingliZhang
Adding additional issue to issue list: 8305112: RISC-V: Typo fix for RVC description.

Adding additional issue to issue list: 8295396: RISC-V: Cleanup useless CompressibleRegions.

Adding additional issue to issue list: 8305512: RISC-V: Enable RVC extension by default on supported hardware.

@DingliZhang
Copy link
Member Author

Testing of fastdebug is ongoing, I will update later.

@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant