-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pySLM2: A full-stack python package for holographic beam shaping #6315
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Failed to discover a valid open source license |
|
@ldes89150, sorry about this, but after deliberations with @kyleniemeyer (our Associate Editor-in-Chief) I believe it would be best to remove the section on Hardware Integration instead of leaving it in with The alternative (preferred) would be having a reviewer with the requisite hardware, but removing the section works as well. |
@ldes89150 yes - we can include that section in the paper, if you are able to help us find an editor with access to the hardware. |
@kyleniemeyer @HaoZeke I can declare there is no conflict of interest. |
hi @wavefrontshaping 👋 would you be interested in and available to review this JOSS submission? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html If not, could you recommend any potential reviewers? |
Hi all, |
@editorialbot add @wavefrontshaping as reviewer Thanks a ton for taking time to review this!
The review checklist is generated here by commenting |
@wavefrontshaping added to the reviewers list! |
Hi, I installed the package in a new environment. First, the dependencies for the docs are not installed when I installed the package, did I do something wrong? Then, after installing the necessary packages, I run into an error: Theme error:
no theme named 'furo' found (missing theme.conf?) How do I solve that? |
👋 @wavefrontshaping FYI, JOSS likes reviewers to use github issues on the being-reviewed repository for their reviews, not post questions, etc in the review issue on JOSS. |
Hey @wavefrontshaping , Thank you so much for helping the review. I opened an issue on github for the problem you encountered. |
Review checklist for @sidihamadyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Issue: Authors can add a header to each source file |
Installation: The package is easy to install and the examples provided allow you to test it without problem. The only example that I can't test is obviously the one that uses the Luxbeam controller since I don't have access to the hardware. |
|
@editorialbot remove @ktahar as reviewer |
Hey @HaoZeke, I've merge it. Thanks! Hopefully there's no other issues with the reference! May I ask what tools you use to check references as editor? Maybe next time we can do the checks ourselves. |
@editorialbot recommend-accept @marvelousmonicaaa generally I was using |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6109, then you can now move forward with accepting the submission by compiling again with the command |
@ldes89150 can you please correct the author list in the Zenodo archive to match the paper? |
or @marvelousmonicaaa, if both of you are authors |
@ldes89150 @marvelousmonicaaa regarding the paper, a few things to fix:
|
@editorialbot check references |
|
@editorialbot generate pdf |
Hi @kyleniemeyer, sorry about the delay. We have fixed most of the issues now. Just one thing to confirm, I noticed the DOI number in the pdf generated by editoialbot is a '10.xxxxx/draft". I wonder if that is autogenerated DOI for this paper and it will be an actual number after it is published? |
@marvelousmonicaaa that paper DOI is a placeholder, it will be updated after accepting. I only see one minor remaining issue: the author field is incorrect for the new Tensorflow citation (appearing as "Developers, T."). Anything that isn't a person's name needs to be protected with extra |
@editorialbot generate pdf |
@kyleniemeyer The tensorflow reference should be good now! Let me know if you spot any new issues! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @ldes89150 & @marvelousmonicaaa on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already. Many thanks to @brandondube, @sidihamady, and @wavefrontshaping for reviewing this, and @HaoZeke for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ldes89150 (Chung-You Shih)
Repository: https://github.com/QITI/pySLM2
Branch with paper.md (empty if default branch): paper
Version: v0.1.0
Editor: @HaoZeke
Reviewers: @brandondube, @sidihamady, @wavefrontshaping
Archive: 10.5281/zenodo.14025566
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@brandondube & @sidihamady & @ktahar & @wavefrontshaping, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @HaoZeke know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @brandondube
📝 Checklist for @sidihamady
📝 Checklist for @wavefrontshaping
The text was updated successfully, but these errors were encountered: