-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added resource manager for tracking and planning resource usage withi… #376
base: master
Are you sure you want to change the base?
Added resource manager for tracking and planning resource usage withi… #376
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nitin-Kashyap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sync |
@sraghunandan: This pr has been synchronized to the Gitee Repository In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository. |
74624f1
to
ad667b7
Compare
/sync |
@sraghunandan: This pr has been synchronized to the Gitee Repository In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository. |
ad667b7
to
af914b3
Compare
/sync |
@sraghunandan: This pr has been synchronized to the Gitee Repository In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository. |
fb39d5c
to
0b76cf1
Compare
/sync |
@sraghunandan: This pr has been synchronized to the Gitee Repository In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository. |
…n and across queries
0b76cf1
to
b820f84
Compare
/sync |
@sraghunandan: This pr has been synchronized to the Gitee Repository In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository. |
@@ -733,6 +741,8 @@ private boolean canScheduleMoreSplits() | |||
{ | |||
long cachedMemoryUsage = queryStateMachine.getResourceGroupManager().getCachedMemoryUsage(queryStateMachine.getResourceGroup()); | |||
long softReservedMemory = queryStateMachine.getResourceGroupManager().getSoftReservedMemory(queryStateMachine.getResourceGroup()); | |||
|
|||
/* Todo(Nitin K) replace with smart scheduler and pull the resource limit from QueryResourceManager/Service */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the plan for this?
@Override | ||
public void setResourceLimit(DataSize memoryLimit, Duration cpuLimit, DataSize ioLimit) | ||
{ | ||
/* Todo(Nitin K) check estimates correctness before updating limits! */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to validate for limits
…n and across queries
What type of PR is this?
/kind feature
What does this PR do / why do we need it:
adds a resource manager placeholder for monitoring and resource planning
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewers: