Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resource manager for tracking and planning resource usage withi… #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nitin-Kashyap
Copy link
Contributor

…n and across queries

What type of PR is this?

/kind feature

What does this PR do / why do we need it:

adds a resource manager placeholder for monitoring and resource planning

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewers:

@it-is-a-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nitin-Kashyap
To complete the pull request process, please assign sraghunandan
You can assign the PR to them by writing /assign @sraghunandan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sraghunandan
Copy link

/sync

@it-is-a-robot
Copy link
Contributor

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to this:

/sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository.

@Nitin-Kashyap Nitin-Kashyap force-pushed the feature-resourceManager branch 2 times, most recently from 74624f1 to ad667b7 Compare July 26, 2022 10:07
@sraghunandan
Copy link

/sync

@it-is-a-robot
Copy link
Contributor

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to this:

/sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository.

@Nitin-Kashyap Nitin-Kashyap force-pushed the feature-resourceManager branch from ad667b7 to af914b3 Compare July 26, 2022 10:47
@sraghunandan
Copy link

/sync

@it-is-a-robot
Copy link
Contributor

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to this:

/sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository.

@Nitin-Kashyap Nitin-Kashyap force-pushed the feature-resourceManager branch 2 times, most recently from fb39d5c to 0b76cf1 Compare August 3, 2022 05:31
@sraghunandan
Copy link

/sync

@it-is-a-robot
Copy link
Contributor

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to this:

/sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository.

@Nitin-Kashyap Nitin-Kashyap force-pushed the feature-resourceManager branch from 0b76cf1 to b820f84 Compare August 4, 2022 01:32
@sraghunandan
Copy link

/sync

@it-is-a-robot
Copy link
Contributor

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to this:

/sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository.

@@ -733,6 +741,8 @@ private boolean canScheduleMoreSplits()
{
long cachedMemoryUsage = queryStateMachine.getResourceGroupManager().getCachedMemoryUsage(queryStateMachine.getResourceGroup());
long softReservedMemory = queryStateMachine.getResourceGroupManager().getSoftReservedMemory(queryStateMachine.getResourceGroup());

/* Todo(Nitin K) replace with smart scheduler and pull the resource limit from QueryResourceManager/Service */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the plan for this?

@Override
public void setResourceLimit(DataSize memoryLimit, Duration cpuLimit, DataSize ioLimit)
{
/* Todo(Nitin K) check estimates correctness before updating limits! */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to validate for limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants