fix: add AsyncLocalStorage to globalThis
#1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
ascorbic
commented
Feb 1, 2023
Comment on lines
-32
to
+45
| it(`${label}should fail when returning a stream`, async () => { | ||
| it(`${label}should not fail when returning a stream`, async () => { | ||
| const res = await fetchViaHTTP(next.url, `${locale}/stream-a-response`) | ||
| expect(res.status).toBe(500) | ||
| expect(res.status).toBe(200) | ||
|
|
||
| if (!(global as any).isNextDeploy) { | ||
| expect(await res.text()).toEqual('Internal Server Error') | ||
| expect(next.cliOutput).toContain( | ||
| expect(next.cliOutput).not.toContain( | ||
| `A middleware can not alter response's body. Learn more: https://nextjs.org/docs/messages/returning-response-body-in-middleware` | ||
| ) | ||
| } | ||
| }) | ||
|
|
||
| it(`${label}should fail when returning a text body`, async () => { | ||
| it(`${label}should not fail when returning a text body`, async () => { | ||
| const res = await fetchViaHTTP(next.url, `${locale}/send-response`) | ||
| expect(res.status).toBe(500) | ||
| expect(res.status).toBe(200) |
There was a problem hiding this comment.
These are test changes from upstream
|
Also for more context, this is to mirror what they're doing in their repo. // expose AsyncLocalStorage on globalThis for react usage
const { AsyncLocalStorage } = require('async_hooks')
;(globalThis as any).AsyncLocalStorage = AsyncLocalStorage |
nickytonline
approved these changes
Feb 1, 2023
| @@ -0,0 +1,11 @@ | |||
| 'use client' | |||
|
|
|||
| // TODO-APP: support typing for useSelectedLayoutSegment | |||
There was a problem hiding this comment.
This is a Next.js demo site, not our code
|
|
||
| // TODO-APP: support typing for useSelectedLayoutSegment | ||
| // @ts-ignore | ||
| import { useSelectedLayoutSegments } from 'next/navigation' |
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since version
13.1.2, Next.js has requiredAsyncLocalStorageto be available on the global object for edge SSR. Deno, being excellent people, have now added an implementation to their node compat library, so this adds that toglobalThis.Test plan
/app-edgein the default demoRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1851
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.