Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating ISM polisies via role #67

Closed
wants to merge 6 commits into from
Closed

Creating ISM polisies via role #67

wants to merge 6 commits into from

Conversation

ssi444
Copy link
Contributor

@ssi444 ssi444 commented May 24, 2022

Description

Added the ability to automatically create ISM policies.

Issues Resolved

#66

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ssi444 added 6 commits May 12, 2022 14:07
@ssi444
Update dashboards.yml. Fix owner and permissions for home folder
6e74ddd 
Signed-off-by: Sergey Shubin <[email protected]>
@ssi444
The validity period of certificates is set to a variable
9925a0c 
Signed-off-by: Sergey Shubin <[email protected]>
@ssi444
change HOME directory for {{ os_user }} and {{ os_dashboards_user }} …
0a5885e 
…and set them /bin/false shell

Signed-off-by: Sergey Shubin <[email protected]>
@ssi444
auth_type (internal, openid). Custom configs, IaC
abf770d 
1. Added the ability to log in via OpenID
2. Added the ability to install custom configuration files for the cluster
3. Added the ability to reconfigure the cluster (in particular, update certificates) when expanding it
4. Added the ability not to change certificates if the cluster composition has not changed, but only the settings have changed.

Signed-off-by: Sergey Shubin <[email protected]>
@ssi444
readme. description for OpenID, IaC, custom configuration files
4b4bf51 
Signed-off-by: Sergey Shubin <[email protected]>
@ssi444
Added the ability to automatically create ISM policies. The "ISM Poli…
1ab0815 
…cies" section have been added to the readme.

Signed-off-by: Sergey Shubin <[email protected]>
@ssi444 ssi444 requested a review from a team as a code owner May 24, 2022 13:53
@ssi444
Copy link
Contributor Author

ssi444 commented May 24, 2022

Calling @saravanan30erd @prudhvigodithi for the review.
Thanks.

@ssi444
Copy link
Contributor Author

ssi444 commented May 31, 2022

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

@peterzhuamazon
Copy link
Member

@saravanan30erd Please let me know if you have bandwidth to review this.
@ssi444 Sorry we are focusing on two minor releases in the past weeks that is why this is pretty slow.
Thanks.

@ssi444
Copy link
Contributor Author

ssi444 commented Jun 21, 2022

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

1 similar comment
@ssi444
Copy link
Contributor Author

ssi444 commented Jun 27, 2022

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

@prudhvigodithi
Copy link
Member

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

1 similar comment
@prudhvigodithi
Copy link
Member

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

@ssi444
Copy link
Contributor Author

ssi444 commented Mar 22, 2023 •
edited
Loading

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

This is one of the important tasks for using this role as an IaC. In production, we most often add ISM and index pattern (PR #68)

@prudhvigodithi
Copy link
Member

Thanks @ssi444, @peterzhuamazon please add your thoughts on this PR and index pattern (PR #68)
Thank you

@peterzhuamazon
Copy link
Member

Thanks @ssi444, @peterzhuamazon please add your thoughts on this PR and index pattern (PR #68) Thank you

Hi all,

We welcome the contribution but it looks like doesn't cater to wider variety of users as it specifically add settings for a plugin or two.

Need more discussion on whether this is addition to the repo, or is just support for user-specific scenario.
Let me know what you guys think @bbarani @gaiksaya @rishabh6788 .

Thanks.

@ssi444
Copy link
Contributor Author

ssi444 commented Mar 23, 2023

If the number of users using this role for regular cluster updates according to the IaC methodology is insignificant, then it may not be worth implementing this PR. We are actively using this in production and I decided to share our best practices with the community. With this role we manage:

  • index pattern
  • ISM
  • installing plugins

There are plans to complete the management of visualizations and dashboards. We don't use them at home, but if the community is interested, then I can make the necessary improvements.

@bbarani
Copy link
Member

bbarani commented Sep 25, 2023

Anyone looking in to this PR? @prudhvigodithi @peterzhuamazon @TheAlgo

@dblock
Copy link
Member

dblock commented Jul 1, 2024

Looks like there was no consensus of what to do with this PR. Closing it as stalled, please reopen if you don't agree!

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

@dblock dblock closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saravanan30erd saravanan30erd Awaiting requested review from saravanan30erd saravanan30erd is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ssi444 @peterzhuamazon @prudhvigodithi @bbarani @dblock