CNF-15663: Full DU profile example #313

irinamihai · 2024-11-15T23:25:30Z

No description provided.

openshift-ci-robot · 2024-11-15T23:25:33Z

@irinamihai: This pull request references CNF-15663 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-11-15T23:25:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from irinamihai. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

irinamihai · 2024-11-15T23:25:43Z

/hold cleanup

irinamihai · 2024-11-18T18:56:15Z

/unhold

browsell · 2024-11-17T20:50:57Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          cluster-log-fwd-outputs:
+            type: string
+          cluster-log-fwd-pipelines:


This should be a default

+1 -- or going a bit further I think this is static content that likely doesn't need to be part of the defaults either.

It has been agreed that this will be locked in the new version of the ClusterLogForwarder, currently WIP under OCPBUGS-44518, so it will be removed from this ClusterTemplate.

browsell · 2024-11-17T20:51:17Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+      policyTemplateParameters:
+        description: policyTemplateSchema defines the available parameters for cluster configuration
+        properties:
+          cluster-log-fwd-filters:


This should be a default

By default, do you mean have them directly in the Policy Generator and not expose them in the policyTemplateParameters?

No, these would be set in the default configmap vs being passed in by the client

As proposed above I think we should narrow this down to just the additional labels. One question I have is whether the user/orchestrator would add one or more labels which are cluster specific (like a higher level cluster identifier, etc)? In that case would the labels (or at least one label) need to be part of this schema?

The filters are also going to be partially locked in in the ClusterLogForwarder source-cr under OCPBUGS-44518. Yes, these labels will be set in the ClusterInstance defaults ConfigMap, but we also need a way for them to reach the ConfigMap used by the ACM PGs, so they need to also be included in the policyTemplate defaults ConfigMap.

browsell · 2024-11-17T20:51:30Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          cluster-log-fwd-pipelines:
+            type: string
+          sriov-fec-bbDevConfig:


browsell · 2024-11-17T20:51:37Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          sriov-fec-bbDevConfig:
+            type: string
+          sriov-fec-pciAddress:


browsell · 2024-11-17T20:52:07Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          sriov-fec-pciAddress:
+            type: string
+          sriov-fec-pfDriver:


browsell · 2024-11-18T19:23:00Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/policytemplates-defaults-v3-full-DU.yaml

+  # (e.g., "40m" for 40 minutes)
+  clusterConfigurationTimeout: "40m"
+  policytemplate-defaults: |
+    cluster-log-fwd-filters: '[{"name":"test-labels", "type": "openshiftLabels", "openshiftLabels": {"label1": "test1", "label2": "test2"}}]'


Not really filters, additional metadata labels

Do we want to narrow the templating down to just the additional labels, ie the user configures only the value for openshiftLabels?

browsell · 2024-11-18T19:29:53Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          hugepages-count:
+            type: string
+          machine-config-storage-source-1:


Remove, see comment above

browsell · 2024-11-18T19:30:03Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          machine-config-storage-source-1:
+            type: string
+          machine-config-storage-source-2:


browsell · 2024-11-18T20:18:45Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          hugepages-count:
+            type: string
+          machine-config-storage-source-1:


browsell · 2024-11-18T20:19:00Z

...samples/git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-v4-Y-Z-6-full-DU.yaml

+            type: string
+          machine-config-storage-source-1:
+            type: string
+          machine-config-storage-source-2:


lack

Generally speaking, if this is something that will need to be kept in-sync with the cnf-features-deploy repo, perhaps it's worth engineering a way to automatically synchronize them or generate one from the other.

lack · 2024-11-19T03:32:22Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/policytemplates-defaults-v3-full-DU.yaml

+  clusterConfigurationTimeout: "40m"
+  policytemplate-defaults: |
+    cluster-log-fwd-filters: '[{"name":"test-labels", "type": "openshiftLabels", "openshiftLabels": {"label1": "test1", "label2": "test2"}}]'
+    cluster-log-fwd-outputs: '[{"type":"kafka","name":"kafka-open", "kafka": {"url":"tcp://10.46.55.190:9092/test"}}]'


Should we allow customization of all of this? Or just the Kafka url?

lack · 2024-11-19T03:40:53Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+          additionalKernelArgs:
+          - rcupdate.rcu_normal_after_boot=0
+          - vfio_pci.enable_sriov=1
+          - vfio_pci.disable_idle_d3=1
+          - efi=runtime


We shouldn't override this section, but rely on the source-crs original value

+1
This is also missing the module_blacklist=irdma

lack · 2024-11-19T03:42:56Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+          machineConfigPoolSelector:
+            pools.operator.machineconfiguration.openshift.io/master: ""
+          nodeSelector:
+            node-role.kubernetes.io/master: ''


Suggested change

machineConfigPoolSelector:

pools.operator.machineconfiguration.openshift.io/master: ""

nodeSelector:

node-role.kubernetes.io/master: ''

machineConfigPoolSelector:

$patch: replace

pools.operator.machineconfiguration.openshift.io/master: ""

nodeSelector:

$patch: replace

node-role.kubernetes.io/master: ''

And then we don't need the SetSelector cr variant any more.

(Repeat for *-SetSelector.yaml elsewhere in this file!)

lack · 2024-11-19T03:45:00Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+              phc2sysOpts: -a -r -n 24
+              ptp4lOpts: -2 -s --summary_interval -4


We shouldn't override these; the source-crs has the right values.

lack · 2024-11-19T03:52:01Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+    - path: source-crs/MachineConfigGeneric.yaml
+      complianceType: mustonlyhave # This is to update array entry as opposed to appending a new entry.
+      patches:
+      - metadata:
+          name: 02-master-workload-partitioning
+        spec:
+          config:
+            storage:
+              files:
+                - contents:
+                    # crio cpuset config goes below. This value needs to be updated and matched with PerformanceProfile. Check the link for more info on the content.
+                    source: '{{hub fromConfigMap "" (printf "%s-pg" .ManagedClusterName) "machine-config-storage-source-1" hub}}'
+                  mode: 420
+                  overwrite: true
+                  path: /etc/crio/crio.conf.d/01-workload-partitioning
+                  user:
+                    name: root
+                - contents:
+                    # openshift cpuset config goes below. This value needs to be updated and matched with crio cpuset (array entry above this). Check the link for more info on the content.
+                    source: '{{hub fromConfigMap "" (printf "%s-pg" .ManagedClusterName) "machine-config-storage-source-2" hub}}'
+                  mode: 420
+                  overwrite: true
+                  path: /etc/kubernetes/openshift-workload-pinning
+                  user:
+                    name: root


i don't think any of this is needed any more since the SiteConfig added cpuPartitioningMode: AllNodes in 4.14

browsell · 2024-11-19T11:07:35Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+      complianceType: musthave
+      patches:
+      - spec:
+          configDaemonNodeSelector:


Wouldn't this be in the source cr ?

The selector can't be, because depending on whether you're deploying SNO or MNO the source CR may need master or worker.

In this model, the cluster template would only be used for SNO, a MNO would have a different one,

For SNO we should be able to use either master or worker here since the node has both labels. If we use worker is it valid for all topologies?

browsell · 2024-11-19T11:08:09Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                summary=Configuration changes profile inherited from performance created tuned
+                include=openshift-node-performance-openshift-node-performance-profile
+                [bootloader]
+                cmdline_crash=-tsc=nowatchdog


Do we need to override the default profile? 🤔 The ztp git example is just using the default profile values.

No need to override the source cr here

browsell · 2024-11-19T11:08:19Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                include=openshift-node-performance-openshift-node-performance-profile
+                [bootloader]
+                cmdline_crash=-tsc=nowatchdog
+                cmdline_crash1=tsc=reliable


browsell · 2024-11-19T11:08:31Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                cmdline_crash=-tsc=nowatchdog
+                cmdline_crash1=tsc=reliable
+                [sysctl]
+                kernel.timer_migration=1


browsell · 2024-11-19T11:08:43Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                cmdline_crash1=tsc=reliable
+                [sysctl]
+                kernel.timer_migration=1
+                kernel.sysrq=1


browsell · 2024-11-19T11:09:13Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                [service]
+                service.stalld=start,enable
+                service.chronyd=stop,disable
+    # MACHINE CONFIG


bartwensley · 2024-11-20T13:38:39Z

docs/cluster-configuration.md

+
+For details about setting up the Git repo, please refer to the the Gitops setup [README.md](./samples/git-setup/README.md).
+
+**Note:** Make sure all the value used in hub templates in the PGs are exposed in the corresponding ClusterTemplate, under `spec.templateParameterSchema.policyTemplateParameters` and are present either in the `spec.templates.policyTemplateDefaults` ConfigMap or are specified through the ProvisioningRequest (`spec.templateParameters.policyTemplateParameters`).


nit: values

bartwensley · 2024-11-20T13:55:44Z

docs/samples/git-setup/policytemplates/version_4.Y.Z/kustomization.yaml

@@ -2,7 +2,8 @@ generators:
 - sno-ran-du/sno-ran-du-pg-v4-Y-Z-v1.yaml
 # This ACM PG is needed when the previous one has to be updated.
 - sno-ran-du/sno-ran-du-pg-v4-Y-Z-v2.yaml
-
+- sno-ran-du/sno-ran-du-pg-v4-Y-Z-v3.yaml
+- sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml


Since this isn't really a progression from v3, but a whole new PG, would it be better to create new sno-ran-full-du directories for the cluster templates and policy templates and start them at v1?

Missxiaoguo · 2024-11-20T15:13:08Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+      - data:
+          config.yaml: |
+            alertmanagerMain:
+              enabled: false
+            telemeterClient:
+              enabled: false


By default, observability is not enabled. I think we should just use the default values from source-cr.

we should enable observability.

Missxiaoguo · 2024-11-20T15:18:04Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

@@ -0,0 +1,376 @@
+apiVersion: policy.open-cluster-management.io/v1


Is this DU profile based on the OCP 4.17? I wonder if adding a comment to mention that might be helpful.

Missxiaoguo · 2024-11-20T15:20:52Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+          name: redhat-operators
+        spec:
+          displayName: redhat-operators
+          image: registry.redhat.io/redhat/redhat-operator-index:v4.Y


Do we want to use disconnected registry as example?

imiller0 · 2024-11-20T20:46:50Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/clusterinstance-defaults-v5-full-DU.yaml

+      ManagedCluster:
+        test-annotation: test


Is this intentional?

imiller0 · 2024-11-20T21:15:09Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/clusterinstance-defaults-v5-full-DU.yaml

+      - name: clustertemplate-sample.v1.0.0-extramanifests
+    nodes:
+      - role: master
+        bootMode: UEFI


Reference is now UEFISecureBoot.

imiller0 · 2024-11-20T21:16:42Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/clusterinstance-defaults-v5-full-DU.yaml

+    networkType: OVNKubernetes
+    sshPublicKey: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDTca4Qyu5AYBmZbSl74cNTKuNINJ7d+ceBRzKUrhHcQpMbl8UnAYhjh/ffTyVCsgwzm1RjTAm6/tPj9euEa+YX4U78Sx+ioLHmjDvACYsti4DekIR+opFwfIw+JTDXoyVv06lOPaTOa/vtgpe+gDEL364j47f3p9H/tGhsLmpjeG3DVAhbqSh3s0IHpd4OzF/r6g6mbPyHadvedkBZp/qeUX054Gc2QqJeg/s/eddPlQDJbmL8yRVkZu+SsFTOEOAtrdA3czeaEaA8s+aWP9PN3X539Ddw3qahyOSCXpCE2eJXPh8DJCBWVEcFFYgmIFVvCQ+o9cjEmIYg6drGGvRV
+    installConfigOverrides: '{"capabilities": {"baselineCapabilitySet": "None", "additionalEnabledCapabilities": ["NodeTuning", "OperatorLifecycleManager", "Ingress"]}}'
+    ignitionConfigOverride: '{"ignition": {"version": "3.2.0"}, "storage": {"files": [{"overwrite": true, "path": "/etc/containers/policy.json", "contents": {"source":"data:text/plain;base64,ewogICAgImRlZmF1bHQiOiBbCiAgICAgICAgewogICAgICAgICAgICAidHlwZSI6ICJpbnNlY3VyZUFjY2VwdEFueXRoaW5nIgogICAgICAgIH0KICAgIF0sCiAgICAidHJhbnNwb3J0cyI6CiAgICAgICAgewogICAgICAgICAgICAiZG9ja2VyLWRhZW1vbiI6CiAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgIiI6IFt7InR5cGUiOiJpbnNlY3VyZUFjY2VwdEFueXRoaW5nIn1dCiAgICAgICAgICAgICAgICB9CiAgICAgICAgfQp9Cgo="}}]}}'


For IBU there is a need for a separate partition for /var/lib/containers. Should this example set that up as well?

yes, good catch

imiller0 · 2024-11-20T21:19:59Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/clusterinstance-defaults-v5-full-DU.yaml

+                name: bond99
+                state: up
+                type: bond


Is there an intent to include ports eth0 and eth1 in this bond, or other ports in it?

imiller0 · 2024-11-20T21:23:06Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/policytemplates-defaults-v3-full-DU.yaml

+  # (e.g., "40m" for 40 minutes)
+  clusterConfigurationTimeout: "40m"
+  policytemplate-defaults: |
+    cluster-log-fwd-filters: '[{"name":"test-labels", "type": "openshiftLabels", "openshiftLabels": {"label1": "test1", "label2": "test2"}}]'


Do we want to narrow the templating down to just the additional labels, ie the user configures only the value for openshiftLabels?

imiller0 · 2024-11-20T22:20:17Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+          outputs: '{{hub fromConfigMap "" (printf "%s-pg" .ManagedClusterName) "cluster-log-fwd-outputs"  | toLiteral hub}}'
+          pipelines: '{{hub fromConfigMap "" (printf "%s-pg" .ManagedClusterName) "cluster-log-fwd-pipelines"  | toLiteral hub}}'
+          filters: '{{hub fromConfigMap "" (printf "%s-pg" .ManagedClusterName) "cluster-log-fwd-filters"  | toLiteral hub}}'


As noted above we should use more fixed content in the source CR (ie be more opinionated) and allow the user to override the URL and labels.

imiller0 · 2024-11-20T22:20:28Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+          serviceAccount:
+            name: collector


Already in source CR

imiller0 · 2024-11-20T22:21:30Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                kernel.panic_on_rcu_stall=1
+                kernel.hung_task_panic=1


These are not in the reference. Is their addition intentional?

imiller0 · 2024-11-20T22:22:01Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                kernel.hung_task_panic=1
+                [scheduler]
+                group.ice-ptp=0:f:10:*:ice-ptp.*
+                group.ice-gnss=0:f:10:*:ice-gnss.*


Missing:
group.ice-dplls=0:f:10:*:ice-dplls.*

imiller0 · 2024-11-20T22:23:49Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                    name: root
+- name: v4-sriov-config-policy
+  manifests:
+    # SRIOV


For all of these we should not repeat any of the content already in the source CR.

imiller0 · 2024-11-20T22:31:55Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+  orderPolicies: true
+policies:
+# REDUCE FOOTPRINT
+- name: v4-footprint-policy


Is there a reason this is in its own policy? This creates more policies than are necessary. Consider combining with the next policy as "baseline config"

Actually, I think this can be included in the v4-config-policy.

Missxiaoguo · 2024-11-20T23:33:02Z

...ples/git-setup/policytemplates/version_4.Y.Z/sno-ran-du/sno-ran-du-pg-v4-Y-Z-v4-full-DU.yaml

+                  path: /etc/kubernetes/openshift-workload-pinning
+                  user:
+                    name: root
+- name: v4-sriov-config-policy


Could sriov configs be included in the v4-config-policy? I don't see the reason why they couldn't be🤔 .

browsell · 2024-11-21T04:28:40Z

...git-setup/clustertemplates/version_4.Y.Z/sno-ran-du/clusterinstance-defaults-v5-full-DU.yaml

+                  enabled: false
+                ipv4:
+                  enabled: false
+                name: bond99


Can we remove the bond, bonding is going to be very rare for this use case

openshift-merge-robot · 2024-11-27T10:39:04Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-11-29T02:05:31Z

@irinamihai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/markdownlint	`1629354`	link	true	`/test markdownlint`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

CNF-15663: Full DU profile example

1629354

irinamihai requested a review from Missxiaoguo November 15, 2024 23:25

openshift-ci bot requested review from pixelsoccupied and sudomakeinstall2 November 15, 2024 23:25

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024

irinamihai requested review from browsell, bartwensley, lack, imiller0 and pixelsoccupied and removed request for pixelsoccupied and sudomakeinstall2 November 18, 2024 18:57

browsell reviewed Nov 18, 2024

View reviewed changes

lack reviewed Nov 19, 2024

View reviewed changes

browsell reviewed Nov 19, 2024

View reviewed changes

bartwensley reviewed Nov 20, 2024

View reviewed changes

Missxiaoguo reviewed Nov 20, 2024

View reviewed changes

imiller0 reviewed Nov 20, 2024

View reviewed changes

Missxiaoguo reviewed Nov 20, 2024

View reviewed changes

browsell reviewed Nov 21, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024

		phc2sysOpts: -a -r -n 24
		ptp4lOpts: -2 -s --summary_interval -4


		For details about setting up the Git repo, please refer to the the Gitops setup [README.md](./samples/git-setup/README.md).

		Note: Make sure all the value used in hub templates in the PGs are exposed in the corresponding ClusterTemplate, under `spec.templateParameterSchema.policyTemplateParameters` and are present either in the `spec.templates.policyTemplateDefaults` ConfigMap or are specified through the ProvisioningRequest (`spec.templateParameters.policyTemplateParameters`).

		@@ -0,0 +1,376 @@
		apiVersion: policy.open-cluster-management.io/v1

CNF-15663: Full DU profile example #313

Are you sure you want to change the base?

CNF-15663: Full DU profile example #313

Conversation

irinamihai commented Nov 15, 2024

openshift-ci-robot commented Nov 15, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Nov 15, 2024

irinamihai commented Nov 15, 2024

irinamihai commented Nov 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

browsell Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lack left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-merge-robot commented Nov 27, 2024

openshift-ci bot commented Nov 29, 2024

openshift-ci-robot commented Nov 15, 2024 •

edited by openshift-ci bot

Loading

browsell Nov 19, 2024 •

edited

Loading