OCPBUGS-42371: Update core reference to ignore automatically-added operator labels #40
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lack The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lack: This pull request references Jira Issue OCPBUGS-42371, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @imiller0 |
| @@ -4,3 +4,6 @@ metadata: | |||
| name: openshift-nmstate | |||
| annotations: | |||
| workload.openshift.io/allowed: management | |||
| labels: | |||
| name: openshift-nmstate | |||
| openshift.io/cluster-monitoring: "true" | |||
There was a problem hiding this comment.
The name appears to be automatically added (though I'm not sure why...) . The monitoring looks to be a specific opt-in. If that is the case it should either be included in the reference CR as well or ignored via metadata.yaml if we don't care.
There was a problem hiding this comment.
@MarSik : What's your verdict? I don't know enough about either of these, or the core RDS, to know which, if either, should be optional.
There was a problem hiding this comment.
We need someone from nmstate or networking here, I have no idea.
openshift-merge-robot
added
the
needs-rebase
…erator labels Signed-off-by: Jim Ramsay <[email protected]>
lack
force-pushed
the
reference/permissive_labels
branch
from
d54c223
to
2f92d0c
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Jim Ramsay [email protected]