Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding backup procedure #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mmorency2021
Copy link
Contributor

backup procedure
All CRs needed for the backup procedure have been added.

Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorency2021
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2024
Copy link

openshift-ci bot commented Dec 2, 2024

Hi @mmorency2021. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@imiller0
Copy link
Contributor

imiller0 commented Dec 2, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2024

### Purpose

The purpose of this procedure is to show how to backup the Hub cluster CRs and Recover in case of failure. It can either be in an active-passive Architecture or just a simple hub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The purpose of this procedure is to show how to backup the Hub cluster CRs and Recover in case of failure. It can either be in an active-passive Architecture or just a simple hub.
The purpose of this procedure is to show how to backup the Hub cluster CRs and Recover in case of failure. It can either be in an active-passive Architecture or just a simple hub.


### Backup Process

#### 1- Create OBC and get the secret Information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### 1- Create OBC and get the secret Information
#### 1- Create OBC and get the secret Information

Comment on lines 68 to 69
name: default
namespace: namespace: open-cluster-management-backup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated "namespace: "


### Before creating the backup ensure that all BMH are labeled correctly to avoid issue when restoration is done

```yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy is also included as a yaml file below. Rather than duplicating the content can you just point to/reference the included yaml. This helps ensure that we don't have content that is out of sync as we make updates/fixes.
Same comment for other CRs in this readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

name: schedule-drtest
namespace: open-cluster-management-backup
spec:
veleroSchedule: "0 */2 * * *" #backup set every 5 mns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this every 30 minutes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake , it is every 2 hours indeed.

Copy link

openshift-ci bot commented Dec 2, 2024

@mmorency2021: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lintcheck 6015d49 link true /test lintcheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants