Add bandwidth metrics to KPIs #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding two metrics to KPIs: - nWorkloadBytesProcessedPerMinuteNetobserv, which tells bandwidth captured by netobserv - nWorkloadBytesProcessedPerMinuteCadvisor, which tells bandwidth captured via container metrics / cAdvisor Both of them are interesting, as they can tell: - That netobserv captured the expected amount of traffic, ie. not dropping too much, and checking correctness at the same time - That the workload traffic isn't affected by netobserv (ie. a drop in cAdvisor metrics is an indication of performance regression with latency induced by netobserv) Those metrics are more reliable than the number of flows for these goals because the workload bandwidth is supposed to be somewhat consistant across runs, whereas number of flows is a more arbitrary measure that is only loosely related to the actual measured bandwidth.
memodi
approved these changes
Dec 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak, memodi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f1c891f
into
openshift-qe:netobserv-perf-tests
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two metrics to KPIs:
nWorkloadBytesProcessedPerMinuteNetobserv, which tells bandwidth captured by netobservnWorkloadBytesProcessedPerMinuteCadvisor, which tells bandwidth captured via container metrics / cAdvisorBoth of them are interesting, as they can tell:
Those metrics are more reliable than the number of flows for these goals because the workload bandwidth is supposed to be somewhat consistant across runs, whereas number of flows is a more arbitrary measure that is only loosely related to the actual measured bandwidth.