Fix biome-ignore issues (#826) #972
Conversation
… & useSortedClasses
… noAccumulatingSpread
|
@shagunsharma6677 is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -2,6 +2,7 @@ import type { Monitor } from "@openstatus/tinybird"; | |||
| import { Tracker as OSTracker, classNames } from "@openstatus/tracker"; | |||
|
|
|||
| import { cn, formatDate } from "@/lib/utils"; | |||
| import { nanoid } from "nanoid"; | |||
There was a problem hiding this comment.
are you sure about using nanoid?
There was a problem hiding this comment.
Hey @thibaultleouay ,
Yes, I have done a bit of my research on using a production-grade way to use keys for React elements, and I found this nanoid package, which has over 37 million weekly downloads with a 10.9 KB unpacked size.
If you can suggest any better options, I am happy to work on that.
| @@ -11,6 +11,9 @@ import { | |||
| CardTitle, | |||
| } from "@/components/marketing/card"; | |||
|
|
|||
| import { Globe } from "@/components/marketing/monitor/globe"; | |||
There was a problem hiding this comment.
Why do. we import globe ?
There was a problem hiding this comment.
The Globe component is imported but not used. I am remove it to clean up the codebase.
| const segmentsWithoutRouteGroup = selectedSegments.filter( | ||
| (segment) => !segment.startsWith("("), | ||
| ); | ||
| // The following function is commented out because it is not currently used in the codebase. |
| // biome-ignore lint/correctness/noUnusedVariables: <explanation> | ||
| function stringToArrayProcess<T>(_string: T) {} | ||
| // Below function is commented as not used to remove biome-ignore | ||
| // function stringToArrayProcess<T>(_string: T) {} |
There was a problem hiding this comment.
please remove the dead code 🔥
…nsharma6677/openstatus into issue/826-fix-biome-ignore
Type of change
Description
Fixed biome-ignore issues related to lint suppression. The following issues have been addressed:
nanoIdpackage for unique keys in looping elements (e.g.,key={skeleton-loading-${nanoid(6)}}).packages/reactto handle strings and variables inclassName(e.g.,className={cn("relative inline-flex h-2 w-2 rounded-full", color)}).forEachwith for loops ormap.acc[key] = value; // Directly assign to the accumulator) instead of the spread operator (e.g.,return { ...acc, [key]: value };).AssertionType,StatusAssertionType, andTextBodyAssertionType.Some issues related to
// biome-ignore lint/correctness/useExhaustiveDependenciesmay cause side effects, so they were not changed. Remaining biome-ignore issues are:React.useEffect(() => { setOpen(false); }, [pathname]);in the menu component (web)useEffect(() => { if (searchParams.has("authorize")) { const authorize = searchParams.get("authorize"); if (!authorize) return; form.setValue("password", authorize); } setLoading(false); }, []);in the password form (web)useEffect(() => { if (document) { const cookie = document.cookie.split("; ").find((row) => row.startsWith(name)); if (!cookie) { setState(defaultValue); return; } const value = cookie.split("=")[1] as T; setState(value); } }, []);inuseCookieState(web)A picture tells a thousand words (if any)
Changes have passed all biome-lint checks.
Before this PR
{Please add a screenshot here}
After this PR
{Please add a screenshot here}
Related Issue (optional)