Skip to content

Commit

Permalink
feat: add sync poolservice and webhook
Browse files Browse the repository at this point in the history
Signed-off-by: wangxye <[email protected]>
  • Loading branch information
wangxye committed Apr 27, 2024
1 parent 60a55c6 commit 77148c3
Show file tree
Hide file tree
Showing 13 changed files with 718 additions and 80 deletions.
21 changes: 21 additions & 0 deletions charts/yurt-manager/templates/yurt-manager-auto-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,27 @@ webhooks:
resources:
- yurtstaticsets
sideEffects: None
- admissionReviewVersions:
- v1
- v1beta1
clientConfig:
service:
name: yurt-manager-webhook-service
namespace: {{ .Release.Namespace }}
path: /mutate-network-openyurt-io-poolservice
failurePolicy: Fail
name: mutate.network.v1alpha1.poolservice.openyurt.io
rules:
- apiGroups:
- network.openyurt.io
apiVersions:
- v1alpha1
operations:
- CREATE
- UPDATE
resources:
- poolservices
sideEffects: None
---
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
Expand Down
7 changes: 7 additions & 0 deletions cmd/yurt-manager/app/options/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type YurtManagerOptions struct {
NodeLifeCycleController *NodeLifecycleControllerOptions
NodeBucketController *NodeBucketControllerOptions
LoadBalancerSetController *LoadBalancerSetControllerOptions
VipLoadBalancerController *VipLoadBalancerControllerOptions
}

// NewYurtManagerOptions creates a new YurtManagerOptions with a default config.
Expand All @@ -61,6 +62,7 @@ func NewYurtManagerOptions() (*YurtManagerOptions, error) {
NodeLifeCycleController: NewNodeLifecycleControllerOptions(),
NodeBucketController: NewNodeBucketControllerOptions(),
LoadBalancerSetController: NewLoadBalancerSetControllerOptions(),
VipLoadBalancerController: NewVipLoadBalancerControllerOptions(),
}

return &s, nil
Expand All @@ -82,6 +84,7 @@ func (y *YurtManagerOptions) Flags(allControllers, disabledByDefaultControllers
y.NodeLifeCycleController.AddFlags(fss.FlagSet("nodelifecycle controller"))
y.NodeBucketController.AddFlags(fss.FlagSet("nodebucket controller"))
y.LoadBalancerSetController.AddFlags(fss.FlagSet("loadbalancerset controller"))
y.VipLoadBalancerController.AddFlags(fss.FlagSet("viploadbalancer controller"))
return fss
}

Expand All @@ -102,6 +105,7 @@ func (y *YurtManagerOptions) Validate(allControllers []string, controllerAliases
errs = append(errs, y.NodeLifeCycleController.Validate()...)
errs = append(errs, y.NodeBucketController.Validate()...)
errs = append(errs, y.LoadBalancerSetController.Validate()...)
errs = append(errs, y.VipLoadBalancerController.Validate()...)
return utilerrors.NewAggregate(errs)
}

Expand Down Expand Up @@ -149,6 +153,9 @@ func (y *YurtManagerOptions) ApplyTo(c *config.Config, controllerAliases map[str
if err := y.LoadBalancerSetController.ApplyTo(&c.ComponentConfig.LoadBalancerSetController); err != nil {
return err
}
if err := y.VipLoadBalancerController.ApplyTo(&c.ComponentConfig.VipLoadBalancerController); err != nil {
return err
}
return nil
}

Expand Down
64 changes: 64 additions & 0 deletions cmd/yurt-manager/app/options/vipbalancercontroller.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
Copyright 2024 The OpenYurt Authors.
Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an AS IS BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package options

import (
"github.com/spf13/pflag"

"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/config"
)

type VipLoadBalancerControllerOptions struct {
*config.VipLoadBalancerControllerConfiguration
}

func NewVipLoadBalancerControllerOptions() *VipLoadBalancerControllerOptions {
return &VipLoadBalancerControllerOptions{
&config.VipLoadBalancerControllerConfiguration{
ConcurrentLoadBalancerSetWorkers: 3,
},
}
}

// AddFlags adds flags related to poolservice for yurt-manager to the specified FlagSet.
func (n *VipLoadBalancerControllerOptions) AddFlags(fs *pflag.FlagSet) {
if n == nil {
return
}

fs.Int32Var(&n.ConcurrentLoadBalancerSetWorkers, "concurrent-load-balancer-set-workers", n.ConcurrentLoadBalancerSetWorkers, "The number of load-balancer-set service objects that are allowed to reconcile concurrently. Larger number = more responsive load-balancer-set services, but more CPU (and network) load")
}

// ApplyTo fills up poolservice config with options.
func (o *VipLoadBalancerControllerOptions) ApplyTo(cfg *config.VipLoadBalancerControllerConfiguration) error {
if o == nil {
return nil
}

cfg.ConcurrentLoadBalancerSetWorkers = o.ConcurrentLoadBalancerSetWorkers

return nil
}

// Validate checks validation of VipLoadBalancerControllerOptions.
func (o *VipLoadBalancerControllerOptions) Validate() []error {
if o == nil {
return nil
}
errs := []error{}
return errs
}
2 changes: 2 additions & 0 deletions pkg/yurtmanager/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/csrapprover"
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/daemonpodupdater"
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/loadbalancerset/loadbalancerset"
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/loadbalancerset/viploadbalancer"
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/nodebucket"
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/nodelifecycle"
"github.com/openyurtio/openyurt/pkg/yurtmanager/controller/nodepool"
Expand Down Expand Up @@ -99,6 +100,7 @@ func NewControllerInitializers() map[string]InitFunc {
register(names.NodeLifeCycleController, nodelifecycle.Add)
register(names.NodeBucketController, nodebucket.Add)
register(names.LoadBalancerSetController, loadbalancerset.Add)
register(names.VipLoadBalancerController, viploadbalancer.Add)

return controllers
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ package config

// VipLoadBalancerControllerConfiguration contains elements describing EdgeLoadBalanceController.
type VipLoadBalancerControllerConfiguration struct {
ConcurrentLoadBalancerSetWorkers int32
}
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ func NewPoolServicePredicated() predicate.Predicate {
}

func predicatedPoolService(ps *v1alpha1.PoolService) bool {
if ps.Labels == nil {
return false
}

return matchLoadBalancerClass(ps)

Check warning on line 66 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go#L65-L66

Added lines #L65 - L66 were not covered by tests
}

Expand All @@ -75,9 +71,9 @@ func matchLoadBalancerClass(ps *v1alpha1.PoolService) bool {
return false

Check warning on line 71 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go#L69-L71

Added lines #L69 - L71 were not covered by tests
}

if *ps.Spec.LoadBalancerClass == VipLoadBalancerClass {
return true
if *ps.Spec.LoadBalancerClass != VipLoadBalancerClass {
return false

Check warning on line 75 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go#L74-L75

Added lines #L74 - L75 were not covered by tests
}

return false
return true

Check warning on line 78 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/predicate.go#L78

Added line #L78 was not covered by tests
}
22 changes: 15 additions & 7 deletions pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package viploadbalancer
import "sync"

const (
MINVRIDLIMIT = 0
MAXVRIDLIMIT = 255
EVICTED = -1
)
Expand All @@ -43,7 +44,7 @@ func (vm *VRIDManager) GetVRID(key string) int {
vm.vridMap[key] = make(map[int]bool)
}

for vrid := 1; vrid <= vm.maxVRID; vrid++ {
for vrid := 0; vrid < vm.maxVRID; vrid++ {
if !vm.vridMap[key][vrid] {
vm.vridMap[key][vrid] = true
return vrid
Expand All @@ -53,12 +54,6 @@ func (vm *VRIDManager) GetVRID(key string) int {
return EVICTED

Check warning on line 54 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go#L54

Added line #L54 was not covered by tests
}

func (vm *VRIDManager) isEmpty(key string) bool {
vm.mutex.Lock()
defer vm.mutex.Unlock()
return len(vm.vridMap[key]) == 0
}

func (vm *VRIDManager) ReleaseVRID(key string, vrid int) {
vm.mutex.Lock()
defer vm.mutex.Unlock()

Check warning on line 59 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go#L57-L59

Added lines #L57 - L59 were not covered by tests
Expand All @@ -84,3 +79,16 @@ func (vm *VRIDManager) isValid(key string, vrid int) bool {

return true

Check warning on line 80 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go#L80

Added line #L80 was not covered by tests
}

func (vm *VRIDManager) SyncVRID(key string, vird []int) {
vm.mutex.Lock()
defer vm.mutex.Unlock()

if _, ok := vm.vridMap[key]; !ok {
vm.vridMap[key] = make(map[int]bool)

Check warning on line 88 in pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go

View check run for this annotation

Codecov / codecov/patch

pkg/yurtmanager/controller/loadbalancerset/viploadbalancer/util.go#L88

Added line #L88 was not covered by tests
}

for _, v := range vird {
vm.vridMap[key][v] = true
}
}

This file was deleted.

Loading

0 comments on commit 77148c3

Please sign in to comment.