feat: bookmark and error response should be skipped in yurthub filter (…

…#1868) (#1953) Signed-off-by: HF <[email protected]> (cherry picked from commit 286a43e) Co-authored-by: HF <[email protected]>
openyurtio · Feb 20, 2024 · cb2055b · cb2055b
1 parent a53a13e
commit cb2055b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/yurthub/filter/filter.go b/pkg/yurthub/filter/filter.go
@@ -238,9 +238,12 @@ func (frc *filterReadCloser) StreamResponseFilter(rc io.ReadCloser, ch chan *byt
 			return err
 		}
 
-		newObj := frc.objectFilter.Filter(obj, frc.stopCh)
-		if yurtutil.IsNil(newObj) {
-			continue
+		newObj := obj
+		// BOOKMARK and ERROR response are unnecessary to filter
+		if !(watchType == watch.Bookmark || watchType == watch.Error) {
+			if newObj = frc.objectFilter.Filter(obj, frc.stopCh); yurtutil.IsNil(newObj) {
+				continue
+			}
 		}
 
 		wEvent := watch.Event{