Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify status of poolservice #2019

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

zyjhtangtang
Copy link
Contributor

What type of PR is this?

/kind design
/sig network

What this PR does / why we need it:

Add two fields AggregateToAnnotations and AggregateToLabels to status

  • AggregateToAnnotations means that this information is aggregated into the annotations of the service
  • AggregateToLabels means that this information is aggregated into the labels of the service

Does this PR introduce a user-facing change?

YES

other Note

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (20594f8) to head (5e1af9d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2019   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         183      183           
  Lines       17831    17831           
=======================================
  Hits         9863     9863           
  Misses       6942     6942           
  Partials     1026     1026           
Flag Coverage Δ
unittests 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@zyjhtangtang I think it is a good idea to sync info from PoolService.Status to upstream Service annotations and labels instead of syncing from annotations/labels to annotations/labels.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Apr 15, 2024
@rambohe-ch rambohe-ch merged commit c0e8d33 into openyurtio:master Apr 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants