Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support viploadbalancer controller #2036

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

fix: remove unused client in service webhook

71bf9ce
Select commit
Loading
Failed to load commit list.
Open

feat: support viploadbalancer controller #2036

fix: remove unused client in service webhook
71bf9ce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 8, 2024 in 0s

56.57% (+0.47%) compared to 3713163

View this Pull Request on Codecov

56.57% (+0.47%) compared to 3713163

Details

Codecov Report

Attention: Patch coverage is 69.06977% with 133 lines in your changes missing coverage. Please review.

Project coverage is 56.57%. Comparing base (3713163) to head (71bf9ce).
Report is 28 commits behind head on master.

Files Patch % Lines
...rset/viploadbalancer/viploadbalancer_controller.go 57.63% 76 Missing and 35 partials ⚠️
...oller/loadbalancerset/viploadbalancer/predicate.go 70.58% 5 Missing and 5 partials ⚠️
...roller/loadbalancerset/viploadbalancer/ip_utils.go 93.44% 4 Missing and 4 partials ⚠️
...anager/webhook/service/v1alpha1/service_default.go 80.00% 1 Missing and 1 partial ⚠️
...anager/webhook/service/v1alpha1/service_handler.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
+ Coverage   56.09%   56.57%   +0.47%     
==========================================
  Files         186      193       +7     
  Lines       18092    18771     +679     
==========================================
+ Hits        10149    10619     +470     
- Misses       6910     7052     +142     
- Partials     1033     1100      +67

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov