Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload files Table #43

Merged
merged 61 commits into from
Aug 15, 2023
Merged

Upload files Table #43

merged 61 commits into from
Aug 15, 2023

Conversation

FledgeXu
Copy link
Collaborator

@FledgeXu FledgeXu commented Aug 9, 2023

Goal

The goal of this PR is to completethe Upload files Table in #40.

Abstract

  • Upload files Table
    • Table view with data
    • File upload progress
    • File status change
    • Metadata display (including hover card)
    • Edit icon (non-functional)
    • Delete icon (functional)

@FledgeXu FledgeXu changed the title [WIP] [WIP] Upload files Table Aug 9, 2023
@FledgeXu FledgeXu changed the title [WIP] Upload files Table Upload files Table Aug 10, 2023
@FledgeXu FledgeXu marked this pull request as ready for review August 10, 2023 14:09
@FledgeXu FledgeXu requested a review from rgaudin August 10, 2023 14:09
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to look nice!!

  • UI glitch: Upload button on top of alert message (at least when there are two messages – see screenshot)
  • Need a UI feedback on draggable-zone so we know it's the right place to drop it. We do have it in the DragToStart mode (background change). I like that the whole table allows droping files 👍
  • Simplify Date display (shorter, remember most of this will happen within a week period)
  • We need a user-confirmation on delete (both single and multiple-select)
  • A feedback alert message on deletion: “File xxx has been removed” and “(2) files has been removed”
  • Table sorting/ordering should be figured out now. It most likely will have significant impact on implementation so better do it now.
  • Upload should be circular so it can have a fixed size and be relevant even when small. Please check if there's an existing usable component out there
  • File types should be more user-friendly, as in the mockup. I think there are libs for that (human-filetypes)
  • Status should not be textual: we have three possibilities:
    • check mark icon when uploaded (REMOTE -- and LOCAL until S3 File Upload #35)
    • red cross icon when it failed to upload. In that case hovering on the icon gives the reason (from the xhr response)
    • progressive spinner/progress during upload (as is now). Add file Upload Status Update #36 will make it smarter in that once uploaded (LOCAL) it will start an interval to check status update with infinite spinner until REMOTE
  • Couldn't see the metadata hover card.
  • In-template code should be minimal: retrieving data and passing it through filters or stuff like this. We want code to be maintained in the script section.
Screenshot 2023-08-10 at 17 51 31

frontend/src/views/ProjectView.vue Outdated Show resolved Hide resolved
frontend/src/components/FileTabRowComponent.vue Outdated Show resolved Hide resolved
@FledgeXu
Copy link
Collaborator Author

Couldn't see the metadata hover card.

What's weird. This should work fine……
You just need to put mouse on metadata part and it should show up properly.
image

@rgaudin
Copy link
Member

rgaudin commented Aug 10, 2023

Screenshot 2023-08-10 at 19 01 55

I've tried every single pixel in the row 😅

@FledgeXu
Copy link
Collaborator Author

I see. The file has to have metadata information and then you put mouse on the metadata part, the hover card will appear.

@FledgeXu FledgeXu requested a review from rgaudin August 15, 2023 14:34
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allllllmost there 😉

frontend/src/components/FileTableRowComponent.vue Outdated Show resolved Hide resolved
frontend/src/views/ProjectView.vue Outdated Show resolved Hide resolved
frontend/src/components/FileTableRowComponent.vue Outdated Show resolved Hide resolved
frontend/src/constants.ts Outdated Show resolved Hide resolved
@FledgeXu FledgeXu requested a review from rgaudin August 15, 2023 16:55
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comment and string. I think the dev compose needs the proper quota

frontend/src/components/UploadFilesComponent.vue Outdated Show resolved Hide resolved
frontend/src/constants.ts Outdated Show resolved Hide resolved
@FledgeXu FledgeXu requested a review from rgaudin August 15, 2023 18:10
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👏

@rgaudin rgaudin merged commit 719fe0d into main Aug 15, 2023
@rgaudin rgaudin deleted the project-view branch August 15, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants