Set isSW to false and add documentation on wbInfo

See webrecorder/wombat#155 (comment) for details about why we need to set isSW to false
openzim · Nov 14, 2024 · 6ae8010 · 6ae8010
1 parent 20bf43f
commit 6ae8010
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/javascript/src/wombatSetup.js b/javascript/src/wombatSetup.js
@@ -288,14 +288,21 @@ export function getWombatInfo(
     // The host of the original url
     wombat_host: orig_host,
 
-    // Extra options ?
-    wombat_opts: {},
+    // We are not running inside a service worker, wombat needs to know about it since
+    // some "magic" URLs like blobs are not available
+    isSW: false,
 
-    // ?
-    enable_auto_fetch: true,
+    // Convert all post request to get request
     convert_post_to_get: true,
+
+    // Not used, we are not replaying in a frame
     target_frame: '___wb_replay_top_frame',
-    isSW: true,
+
+    // Not used, we are not running in live mode
+    enable_auto_fetch: false,
+
+    // Extra options, not used
+    wombat_opts: {},
   };
 }
 

diff --git a/javascript/test/wombatSetup.js b/javascript/test/wombatSetup.js
@@ -22,7 +22,7 @@ test('nominalWbInfo', (t) => {
   t.is(wmInfo.coll, '');
   t.is(wmInfo.convert_post_to_get, true);
   t.is(wmInfo.enable_auto_fetch, true);
-  t.is(wmInfo.isSW, true);
+  t.is(wmInfo.isSW, false);
   t.is(wmInfo.is_framed, false);
   t.is(wmInfo.is_live, false);
   t.is(wmInfo.mod, '');