Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds eureka support to micrometer example #114

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Feb 14, 2024

This shows how micrometer traced apps can discover zipkin with eureka

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt changed the title WIP: micrometer tracing plus eureka Adds eureka support to micrometer example May 24, 2024
@codefromthecrypt codefromthecrypt requested a review from reta May 24, 2024 04:02
@codefromthecrypt codefromthecrypt marked this pull request as ready for review May 24, 2024 04:02

/**
* It is very difficult to stop loadbalancer or discovery from initializing when starters are on
* the classpath. This is a workaround to disable it when EUREKA_SERVICE_URL is not set.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codefromthecrypt codefromthecrypt merged commit 6a28c25 into master May 24, 2024
10 checks passed
@codefromthecrypt codefromthecrypt deleted the micrometer-eureka branch May 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants