build: Make libSDL2 optional and only link orblcd against it #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building this suite on Windows 10 under Msys2 UCRT64 I encountered that I have to extract libSDL2.dll and carry it in the "redist" archive to be able to run any of resulting binaries on other machines. Also nothing compiled until I installed said libSDL2 via pacman.
Looking at #143 I wrote a small patch, knowing very little meson, which decouples libSDL2 from command-line tools, and that hypothetically allows me to omit both
orblcd
and libSDL2.dll and have smaller redist archives (we don't use orblcd in our development workflows).This is a follow-up to the discussion from 10 days ago.
Ignore the libasan, what's important is only needed libraries are linked for each respective tool. I have yet to test this on Windows, so please allow some time before merging.
If ucrt64 actually links more than needed, then I may want to decouple libzmq in a similar way (we don't use orbzmq either). I'm open for discussion whether my meson-fu allows me to tackle that here.