Try to make mac build instructions clearer #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on M1 macos went much smoother than windows for me!
I didn't feel like the conclusion from #63 was as obvious as it could be, which is that if you haven't done any tinkering in Rosetta, all you need to do to build is just start the build- don't export the environment variables.
I accidentally set them but it's easy to unset them with
unset(for anyone else who accidentally does the same :)I snuck my missing windows dependency
mingw-w64-x86_64-libelfin here too (#151 ) but I can take it out if you think that it was just an issue with my personal build environment and not something that needs to be in the documentation.