Add unit to CSS zero-length variables #819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
changed the title
MatTheCat
force-pushed
the
ticket_757
branch
from
07e3a7c to
fbf8a14
Compare
nwalters512
reviewed
Dec 3, 2024
Comment on lines
+84
to
+85
| --ts-pr-clear-button: 0em; | ||
| --ts-pr-caret: 0rem; |
There was a problem hiding this comment.
Is there any reason two different units are used here? Of course, it shouldn't matter much, as 0 of anything is 0 of anything else.
There was a problem hiding this comment.
This PR adds the same unit used when the variable is not zero.
As it could be whatever unit this seemed a good baseline to me.
bestpractical-mirror
pushed a commit
to bestpractical/rt
that referenced
this pull request
Dec 16, 2024
Without units, the CSS max function calculates a value of 0, which results in no right margin on dropdowns. This causes the width on col-auto to overlap the value and the dropdown caret. This may be fixed in future tom-select, see PR: orchidjs/tom-select#819
bestpractical-mirror
pushed a commit
to bestpractical/rt
that referenced
this pull request
Dec 17, 2024
Without units, the CSS max function calculates a value of 0, which results in no right margin on dropdowns. This causes the width on col-auto to overlap the value and the dropdown caret. This may be fixed in future tom-select, see PR: orchidjs/tom-select#819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unitless values make CSS computations fail and return zero, which impacts
ts-wrapper’s end padding if either the clear button or caret is missing.This PR adds the same unit used when the variable is not zero.
Fixes #757