Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit to CSS zero-length variables #819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Add unit to CSS zero-length variables #819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scss/tom-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ $select-spinner-border-color: $select-color-border !default;
@import "../plugins/remove_button/plugin.scss";

:root {
--ts-pr-clear-button: 0;
--ts-pr-caret: 0;
--ts-pr-clear-button: 0em;
--ts-pr-caret: 0rem;
Comment on lines +84 to +85
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason two different units are used here? Of course, it shouldn't matter much, as 0 of anything is 0 of anything else.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds the same unit used when the variable is not zero.

As it could be whatever unit this seemed a good baseline to me.

--ts-pr-min: .75rem;
}

Expand Down