Fix dropdown scrolling to top when the virtual scroll plugin fetch next page #821
+37
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556 (closed for inactivity but still present).
I stumbled upon two distinct issues when investigating this one:
lastQuery
property was used for checking the UI staleness, as such it was often reset independently of the search query. When the virtual scroll plugin triggersrefreshOptions
the UI is stale so the first option is activated and scrolled to, while it shouldn’t happen since the query didn’t change. This is fixed by splitting the staleness check in aisDropdownContentStale
property, which is updated independently oflastQuery
.refreshOptions
which then won’t find it in the dropdown and activate — and scroll to — the first option.