-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign for inscription and output #4027
Merged
raphjaph
merged 21 commits into
ordinals:master
from
raphjaph:sign-for-inscriptions-and-output
Nov 26, 2024
Merged
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f79fc74
BIP322 sign file
raphjaph 753c86f
BIP322 sign for inscription and output
raphjaph eb2dd74
Amend
raphjaph 4c7b6cf
Merge branch 'master' of github.com:ordinals/ord into sign-file
raphjaph 3aa258a
Write test
raphjaph 40c9c29
Amend
raphjaph d563160
Merge branch 'master' of github.com:ordinals/ord into sign-for-inscri…
raphjaph cd44a61
Merge branch 'sign-file' into sign-for-inscriptions-and-output
raphjaph f2ee377
Merge branch 'master' of github.com:ordinals/ord into sign-for-inscri…
raphjaph cfe4877
Merge branch 'master' into sign-for-inscriptions-and-output
raphjaph 260356a
Address review comments
raphjaph 8fa9cb7
Amend
raphjaph d5e0760
Amend
raphjaph 26e94c6
Amend
raphjaph 5c7c517
Merge branch 'master' of github.com:ordinals/ord into sign-for-inscri…
raphjaph 281a044
Amend
raphjaph ab3a6ed
Amend
raphjaph f99458b
Amend
raphjaph 42ed80b
Amend
raphjaph c3e3769
Amend
raphjaph 7a29f86
Amend
raphjaph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's combine these into a
Signer
enum. We could either have this as an argument, or maybe a--sign-with
flag.