Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DO NOT MERGE UNTIL READY TO SUPPORT NEW OSCAL DRAFT] support draft OSCAL proposal and mapping #1322

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

fsuits
Copy link
Contributor

@fsuits fsuits commented Mar 15, 2023

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Code changes to support draft OSCAL schema and associated mapping classes

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

fsuits added 2 commits March 15, 2023 15:12
Signed-off-by: Frank Suits <[email protected]>
Signed-off-by: Frank Suits <[email protected]>
@fsuits fsuits requested a review from enikonovad March 15, 2023 04:17
@fsuits fsuits changed the title feat: simplified pr containing only changes needed to support draft OSCAL proposal and mapping feat: [DO NOT MERGE UNTIL READY TO SUPPORT NEW OSCAL DRAFT] support draft OSCAL proposal and mapping Mar 16, 2023
@fsuits fsuits marked this pull request as ready for review March 16, 2023 01:44
@butler54
Copy link
Collaborator

butler54 commented Aug 8, 2024

@jpower432 I think this should be closed. I think it conflicts with the work that @degenaro has completed.

@butler54 butler54 requested review from degenaro, butler54 and jpower432 and removed request for enikonovad August 8, 2024 00:05
@degenaro
Copy link
Collaborator

degenaro commented Aug 8, 2024

@butler54 @jpower432 Please leave this open, until OSCAL mapping model is officially released by NIST and incorporated into trestle. The underlying branch is actively used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants