Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task cis-xlsx-to-oscal-cd #1764

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

Conversation

degenaro
Copy link
Collaborator

@degenaro degenaro commented Dec 2, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

Signed-off-by: Lou DeGenaro <[email protected]>
@degenaro degenaro requested a review from a team as a code owner December 2, 2024 21:03
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the code to fix issue on Python 3.9


@staticmethod
def compare(item1, item2):
"""Compare."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing "@staticmethod" annotation to compare function solved the issue on python 3.9

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Will give it a try...

Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants