Remove unused period editing functions

Periods can no longer be created, updated, or deleted. Remove the functions and Firestore rules for it.
oslokommune · Sep 1, 2023 · 41df65c · 41df65c
1 parent 3b84a1f
commit 41df65c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 65 deletions.
diff --git a/firestore.rules b/firestore.rules
@@ -69,7 +69,9 @@ service cloud.firestore {
       return userIsTeamMember;
     }
 
-    // Is a member from the parent of the Objective/KeyResult/Period/KPI
+    /**
+     * Return true if the current user is a member of `document.parent`.
+     */
     function isMemberOfParent(document, type) {
       let userRef = /databases/$(database)/documents/users/$(request.auth.token.email);
       let doc = getAfter(/databases/$(database)/documents/$(type)/$(document));
@@ -149,9 +151,6 @@ service cloud.firestore {
 
     match /periods/{document} {
       allow read: if isSignedIn();
-      allow create: if isSuperAdmin() || isMemberOfParent(document, 'periods') || isAdminOfParent(document, 'periods');
-      allow update: if isSuperAdmin() || isMemberOfParent(document, 'periods') || isAdminOfParent(document, 'periods');
-      allow delete: if isSuperAdmin();
     }
 
     match /kpis/{document} {

diff --git a/src/db/Period/Period.js b/src/db/Period/Period.js
diff --git a/src/db/Period/index.js b/src/db/Period/index.js
diff --git a/src/db/Period/props.js b/src/db/Period/props.js