Skip to content

Commit

Permalink
Merge pull request #984 from oslokommune/node-20
Browse files Browse the repository at this point in the history
Upgrade to Node.js 20 (LTS)
  • Loading branch information
simenheg authored Oct 17, 2024
2 parents d84a8ce + 8000892 commit 9cd4ddf
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 10 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deploy-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
- name: Checkout
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2

- name: Use Node.js 18
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
- name: Use Node.js 20
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 18
node-version: 20

- name: Populate env file
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
node-version: [20.x]

steps:
- name: Checkout repository
Expand All @@ -32,7 +32,7 @@ jobs:
${{ runner.os }}-${{ hashFiles('package-lock.json') }}
- name: Use Node.js ${{matrix.node-version}}
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: ${{ matrix.node-version }}

Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file. The format

## [UNRELEASED]

### Changed

- Node.js 20 is now the default runtime for all Cloud Functions and when running
the app locally.

### Removed

- Dropped support for Node.js 18 and below.

### Security

- Updated dependencies.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ If you would like to check out how the application works, you can go to the demo

## Project requirements

- Node 18.x
- Node 20.x
- Firebase 10.x
- Firebase tools >9.x
- Firebase Blaze plan - Pay as you go
Expand Down
2 changes: 1 addition & 1 deletion functions/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"logs": "firebase functions:log"
},
"engines": {
"node": "18"
"node": "20"
},
"dependencies": {
"cors": "^2.8.5",
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"export_mock_data": "firebase emulators:export ./mock_data"
},
"engines": {
"node": "18"
"node": "20"
},
"dependencies": {
"@oslokommune/punkt-vue2": "^9.2.6",
Expand Down

0 comments on commit 9cd4ddf

Please sign in to comment.