Get rid of the typography module #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenheg
force-pushed
the
rid-typography-module
branch
3 times, most recently
from
c60a1e3
to
8a259f7
Compare
petterhj
approved these changes
Sep 1, 2023
| @@ -91,7 +89,7 @@ export default { | |||
| } | |||
|
|
|||
| .pkt-form-label { | |||
| font-size: typography.$font-size-1; | |||
| margin: 0.25rem 0; | |||
There was a problem hiding this comment.
Formålet her er å øke avstanden mellom valgene? Radio og label er litt ute av alignment nå, så kunne alt økt margin top/bottom margin i &__item muligens?
Get rid of the typography style module. Use Punkt text classes and mixins directly instead, which also ensures more correct usage of line height and letter spacing according to Punkt. The remains of the module are split into two new `titles` and `markdown` modules.
simenheg
force-pushed
the
rid-typography-module
branch
from
8a259f7
to
05b2eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the typography style module. Use Punkt text classes and mixins directly instead, which also ensures more correct usage of line height and letter spacing according to Punkt. The remains of the module are split into two new
titlesandmarkdownmodules.