Add objective contributors create/remove functions #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenheg
force-pushed
the
objective-contributors-add-delete
branch
4 times, most recently
from
8dfddff
to
5f7cfc7
Compare
petterhj
approved these changes
Sep 12, 2023
firestore.rules
Outdated
Comment on lines
92
to
95
| /** | ||
| * Return true if the current user is a member of the parent of the | ||
| * document's objective *before* performing the action. | ||
| */ |
There was a problem hiding this comment.
Har du sett noe rundt syntaks for kommentarer i CEL? Er det bare // som egentlig er akseptert? (Min syntax-highlighter er ikke så glad, men er heller ikke så veldig farlig.)
There was a problem hiding this comment.
Ah, hm. Ser ut som de andre kommentarene blir ignorert også, men da bytter jeg dem om.
| }, | ||
| objective: { | ||
| type: 'reference', | ||
| required: false, |
There was a problem hiding this comment.
Denne skal ikke være påkrevd?
Add create and remove functions for the new objective contributors collection.
simenheg
force-pushed
the
objective-contributors-add-delete
branch
from
5f7cfc7
to
e63e700
Compare
simenheg
force-pushed
the
objective-contributors-add-delete
branch
from
e63e700
to
f801fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add create and remove functions for the new objective contributors collection.