Don't catch exceptions in backup/restore functions #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenheg
force-pushed
the
backup-and-restore-dont-catch-errors
branch
from
b6abef2
to
69e5ad2
Compare
simenheg
force-pushed
the
backup-and-restore-dont-catch-errors
branch
from
69e5ad2
to
523edb3
Compare
petterhj
approved these changes
Apr 5, 2024
Don't catch exceptions that arise in the backup and restore functions, otherwise GCP won't properly interpret them as errors.
simenheg
force-pushed
the
backup-and-restore-dont-catch-errors
branch
from
523edb3
to
db3fc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't catch exceptions that arise in the backup and restore functions, otherwise GCP won't properly interpret them as errors.