Enable edit labels #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is SBB-specific.
…heBundesbahnen#211) * fix: disable notes in filter sidebar in standalone mode Notes are disabled in standalone mode. * If the backend is turned off, the notes - labels will no longer be displayed in the filter. To keep everything consistent, these labels will also be deactivated in the filter and hidden in the note-edit dialog. --------- Co-authored-by: adrian_egli <[email protected]>
…Bundesbahnen/disable-backend-node-links fix: disable links section in node sidebar in standalone mode
…ahnen#217) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ahnen#219) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- changed Version
added manifest-file: .release-please-manifest.json to release please
Release-As: 2.7.3
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
comments/documentation added
* create/delete node * remove label operation logic * definition of all operations * node operations * trainrun operations * lint * remove unnecessary comments * remove unnecessary param + add objectType to Operation payload * simplify operation design for first use * refactor operation classes with OperationObjectType * add documentation * remove generic * drop generic in operation sub-classes * rename documentation + lint
…chweizerischeBundesbahnen#228) * Fix tag patterns complying with extended tags from release-please. Signed-off-by: chenkins <[email protected]> * Fix link in documentation. Signed-off-by: chenkins <[email protected]> --------- Signed-off-by: chenkins <[email protected]>
…desbahnen#230) According to the sbb-angular docs [1], the sbb-header-environment component should be disabled in production. Do so in standalone mode. Without this, a ribbon with a "standalone" text is displayed in the top-left corner. [1]: https://github.com/sbb-design-systems/sbb-angular/blob/main/src/angular/header-lean/header-lean.md#environment
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Release-As: 2.7.5
…ahnen#234) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* removed unrequired packages * All patches updates (npx npm-check-updates -u -t patch)
Keyboard elements (buttons) will visually highlight.
…bahnen#247) - if so, press ... - for more details ... - Visibility
…Bundesbahnen#245) - ... system saves it ... - ... Use the copy-paste idea: Select the train and press ...
…rischeBundesbahnen#248) Fixes a few issues: - "keyup" is not triggered when copy-pasting. So if the user right clicks and pastes a new value, the name would not get updated. - "keyup" triggers each time a character is typed in the input field. This results in a lot of operations on each keypress. - No need to set this.nodeProperties.nodeBetriebspunktName nor this.nodeProperties.nodeBetriebspunktFullName on keyup: this is already done automatically by [ngModel]. Note that we do loose a bit of functionality with this patch: the diagrams and sidebar headings aren't updated in real-time as the user types anymore.
- Times along edges in the editor main view - Input fields in the train run section form - Times and input fields in the perlenkette - Edges in the streckengrafik - Enforce source/target section ordering
The dark theme doesn't look great when embedded inside OSRD, which has only a light theme.
The trainrun return is still displayed there. TODO: fix that.
This reverts commit cc18f00.
emersion
force-pushed
the
standalone
branch
2 times, most recently
from
968e882 to
04c7674
Compare
|
Label Operation has to be created and pushed to the main repo of NGE instead of our fork -> This PR has to be closed and another one to be opened to enable only the trainrun labels update component |
Uriel-Sautron
force-pushed
the
standalone
branch
from
04c7674 to
07ccfd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
Checklist
documentation/