Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacktrace to error log when subscriber.process/1 fails #177

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JediLuke
Copy link

@JediLuke JediLuke commented Oct 20, 2022

//cc @otobus @mustafaturan

Description

Update logger.error function to use Stacktrace, to make tracing the source of errors easier.

Changes

Added STACKTRACE to the params when logging the error

Is it ready?

  • Created an issue and defined what the problem is
  • Fixed the defined issue
  • The changes have only one commit (if possible please answer the why question with your commit message, and ofcourse a commit may have multiple messages)
  • The changes don't break current functionality
  • All tests are covered and passing travis
  • Used Elixir formatter for only modified file and fixed any of them breaks current consistency.
  • Added specs and docs if a new function introduced
  • Updated specs and docs if changed any params of a function
  • Updated changelog
  • Updated readme
  • Didn't bump the version

References

No custom error handler, this just adds the stacktrace to the error message, which was an annoyance I had when developing.

Love this project by the way ❤️

@mustafaturan
Copy link
Member

mustafaturan commented Oct 28, 2022

Hi @JediLuke ,
Thanks for the contribution, can you please merge your change into 1 commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants