Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter for Controlling PCL PointType #29

Closed
generush opened this issue Jan 31, 2020 · 2 comments · Fixed by #253
Closed

Parameter for Controlling PCL PointType #29

generush opened this issue Jan 31, 2020 · 2 comments · Fixed by #253
Assignees
Labels
enhancement New feature or request

Comments

@generush
Copy link

generush commented Jan 31, 2020

Hello,

Thanks for the Ouster driver, it's works well! I would like to make one request, which is to my knowlesge, the user does not have any control over what fields the Ouster publishes. The driver will always publish X, Y, Z, intensity, t, reflectivity, ring, noise, and range. This is a lot of data that to most users is not necessary. In my specific application, I want XYZI because I am fusing the point cloud with XYZI point clouds from other depth sensors onboard a robot. Therefore, having the same PointType is convenient. I can envision other folks wanting to disable fields they don't need to reduce the amount of computational/communications resources required to run the driver.

In order to resolve this issue, I had to make changes to the driver source code (ouster_ros/include/ouster_ros/point_os1.h), which I would prefer to not do.

Hacky solution: commented out unwanted PCL fields

Thanks!

Gene

@dmitrig dmitrig added the enhancement New feature or request label Dec 7, 2020
@dmitrig
Copy link

dmitrig commented Dec 7, 2020

Thanks for the feedback! We're looking into making the sensor output more configurable, including the ability to turn off unneeded fields, though we don't have an eta available.

@dmitrig dmitrig closed this as completed Dec 7, 2020
@Samahu Samahu reopened this Nov 14, 2022
@Samahu Samahu transferred this issue from ouster-lidar/ouster-sdk Nov 14, 2022
@Samahu Samahu self-assigned this Nov 14, 2022
@Samahu
Copy link
Contributor

Samahu commented Nov 8, 2023

@generush PR #216 should implement this feature, feel free to review and provide feedback before it gets merged. It is currently targeting ros2 only but will be back-ported to ROS1 afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants