Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SW-5657: Back port SW-5466 to ROS-1 #253

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Nov 14, 2023

Related Issues & PRs

Summary of Changes

  • added the ability to customize the published point clouds(s) to velodyne point cloud format and
    other common pcl point types.
  • made ouster_image_nodelet operate separately from ouster_cloud_nodelet
  • added a note to CHANGLOG.rst indicating that the default ptp_utc_tai_offset forms a breaking change.
  • require C++17 for the ROS1 driver starting with v0.11 (C++14 🙅)

Validation (TBD)

  • Run the driver with default parameters and verify no observable behavioral changes.
  • Change point_type parameter to native and verify that it reflects the same point cloud format that we get from the sensor.
  • Change point_type parameter to xyz and verify that the published point cloud format only has xyz fields, regardless of the underlying sensor format.
  • Change point_type parameter to xyzi and verify that the published point cloud format only has xyz fields plus intensity, regardless of the underlying sensor format (you should get a warning when the low data mode is selected for this mode).
  • Change point_type parameter to xyzir and verify that the published point cloud format only has xyz fields plus intensity plus ring, regardless of the underlying sensor format (you should get a warning when the low data mode is selected for this mode).

@Samahu Samahu added the enhancement New feature or request label Nov 14, 2023
@Samahu Samahu self-assigned this Nov 14, 2023
@Samahu Samahu changed the title Port configurable point cloud feature to ros1 SW-5657: Back port SW-5466 to ROS-1 Nov 14, 2023
@Samahu Samahu marked this pull request as ready for review November 15, 2023 23:15
@Samahu Samahu merged commit 4b43332 into master Nov 16, 2023
1 check passed
@Samahu Samahu deleted the SW-5657-back-port-sw-5466-to-ros-1 branch February 2, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant