Shutdown when can not connect to sensor on startup in ROS2 (Humble/Iron) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samahu
changed the title
Samahu
changed the title
Samahu
requested review from
bexcite,
twslankard,
celentes,
pallenouster and
chrisbayruns
bexcite
approved these changes
Sep 12, 2023
Samahu
deleted the
ROS-209-process-hangs-on-failure-to-connect-to-lidar
branch
Samahu
added a commit
that referenced
this pull request
Nov 1, 2023
commit a8990f9 Author: Ussama Naal <[email protected]> Date: Wed Nov 1 14:32:28 2023 +0300 SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (#244) * rename package ouster_msgs to avoid conflict name conflict in ros index * set ouster_sensor_msgs version number to match with ouster_ros package commit 87d6d49 Author: Ussama Naal <[email protected]> Date: Tue Sep 12 13:59:11 2023 -0700 Shutdown when can not connect to sensor on startup in ROS2 (Humble/Iron) (#211) * Shutdown when can not connect to sensor on startup * Apply same behavior to independent launch file * Update changelog and package version
Samahu
added a commit
that referenced
this pull request
Nov 1, 2023
commit 81387db Author: Ussama Naal <[email protected]> Date: Wed Nov 1 06:04:07 2023 -0700 0.11.1 commit a8a9a10 Author: Ussama Naal <[email protected]> Date: Wed Nov 1 06:03:58 2023 -0700 Add a forthcoming entry commit deadb60 Author: Ussama Naal <[email protected]> Date: Wed Nov 1 05:59:15 2023 -0700 Squashed commit of the following: commit a8990f9 Author: Ussama Naal <[email protected]> Date: Wed Nov 1 14:32:28 2023 +0300 SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (#244) * rename package ouster_msgs to avoid conflict name conflict in ros index * set ouster_sensor_msgs version number to match with ouster_ros package commit 87d6d49 Author: Ussama Naal <[email protected]> Date: Tue Sep 12 13:59:11 2023 -0700 Shutdown when can not connect to sensor on startup in ROS2 (Humble/Iron) (#211) * Shutdown when can not connect to sensor on startup * Apply same behavior to independent launch file * Update changelog and package version commit 1c8894a Author: Ussama Naal <[email protected]> Date: Tue Sep 5 10:18:57 2023 -0700 rolling-0.10.4 commit 5eda338 Author: Ussama Naal <[email protected]> Date: Tue Sep 5 10:17:48 2023 -0700 reset version to 0.10.3
AchmadFathoni
pushed a commit
to AchmadFathoni/ouster-ros
that referenced
this pull request
Feb 16, 2024
…on) (ouster-lidar#211) * Shutdown when can not connect to sensor on startup * Apply same behavior to independent launch file * Update changelog and package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Summary of Changes
Validation
While sensor is properly wired launch ouster_ros throughdriver.launch.pyorsensor.independent.launch.pyVerify the node configures and connects to the sensor as normalDisconnect the sensor and then launch ouster_ros throughdriver.launch.pyorsensor.independent.launch.pyVerify the node fails to connect and then shuts down as expected with an error message.