Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-389 [noetic]: replay-improvments-and-fixes #392

Merged
merged 5 commits into from
Oct 30, 2024
Merged

ROS-389 [noetic]: replay-improvments-and-fixes #392

merged 5 commits into from
Oct 30, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Oct 28, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Remap /metadata topic
  • Support loop capability in pcap replay
  • Add play_delay to regular replay and pcap replay
  • Expose play_rate for the bag file replay
  • Added a launch file parameter pub_static_tf to disable sensor transforms broadcast

Validation

  • Test the newly exposed flags for replay_pcap
roslaunch ouster_ros replay_pcap.launch pcap_file:=<...> json_file:=<...> loop:=true play_delay:=10
  • Test the newly exposed flags for bag replay
roslaucn ouster_ros replay_pcap.launch bag_file:=<...> loop:=true play_delay:=10 play_rate:=1.5
  • Test that setting pub_static_tf to false disables the publish of sensor tf transforms:
    image

@Samahu Samahu added the enhancement New feature or request label Oct 28, 2024
@Samahu Samahu self-assigned this Oct 28, 2024
@Samahu Samahu changed the title Remap metadata topic + add loop to pcap + add play delay & play rate ROS-389-replay-improvments-and-fixes Oct 28, 2024
@Samahu Samahu changed the title ROS-389-replay-improvments-and-fixes ROS-389[noetic]: replay-improvments-and-fixes Oct 28, 2024
@Samahu Samahu changed the title ROS-389[noetic]: replay-improvments-and-fixes ROS-389 [noetic]: replay-improvments-and-fixes Oct 29, 2024
@Samahu Samahu mentioned this pull request Oct 29, 2024
Merged
@Samahu Samahu marked this pull request as ready for review October 30, 2024 15:53
@Samahu Samahu merged commit 9711abd into master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lidar matthew-lidar matthew-lidar approved these changes

@twslankard twslankard Awaiting requested review from twslankard

@celentes celentes Awaiting requested review from celentes

@Krishtof-Korda Krishtof-Korda Awaiting requested review from Krishtof-Korda

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

@diego-guridi diego-guridi Awaiting requested review from diego-guridi

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samahu @matthew-lidar