Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase client RECV_BUFF size to 1 MB #547

Closed
wants to merge 2 commits into from

Conversation

ahuazuipiaoliang
Copy link

Related Issues & PRs

ouster-lidar/ouster-ros#190

Summary of Changes

increase buffer size

Validation

Tested with my LiDAR

@Samahu Samahu self-assigned this Aug 14, 2023
@Samahu Samahu self-requested a review August 14, 2023 16:32
@Samahu Samahu added bug Something isn't working enhancement New feature or request labels Aug 14, 2023
@Samahu
Copy link
Collaborator

Samahu commented Aug 14, 2023

@ahuazuipiaoliang Thanks for submitting the PR, this is rather a known issue to us and increasing the RECV_BUFF size is needed. 1 MB seems to be the minimum value to resolve the issue. Since this involves the main the SDK and the ROS driver this involves some process to get it merged. Note that in order for this fix to work it also requires to increase network reception as I noted before: buffer ouster-lidar/ouster-ros#190 (comment). I will circle back with you on merging the fix soon.

@ahuazuipiaoliang
Copy link
Author

@Samahu I've already modified the network reception but it didn't work, after modifying the RCVBUF_SIZE, it worked.

@Samahu
Copy link
Collaborator

Samahu commented Aug 17, 2023

I was trying to say that you need both things to be done, at least for some of the devices that I tested. You could verify that by resetting the size of network reception.

@Samahu Samahu changed the title fix: resolve issue data lost for REV 7 128 LiDARs Resolve issue data lost for REV 7 128 LiDARs Aug 22, 2023
@Samahu Samahu closed this Aug 23, 2023
@Samahu Samahu reopened this Aug 23, 2023
@Samahu Samahu changed the title Resolve issue data lost for REV 7 128 LiDARs Increase RECV_BUFF size to 1 MB Aug 23, 2023
@Samahu Samahu changed the title Increase RECV_BUFF size to 1 MB Increase client RECV_BUFF size to 1 MB Aug 23, 2023
@Samahu
Copy link
Collaborator

Samahu commented Aug 23, 2023

Incorporated the changes into PR #548 to be able to edit before merge (since maintainers weren't given permission to edit the PR).

@Samahu Samahu closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants