-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swiftlint #1757
base: main
Are you sure you want to change the base?
Fix swiftlint #1757
Conversation
MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 7 | 0 | 0.02s | |
✅ BASH | shellcheck | 7 | 0 | 0.32s | |
✅ BASH | shfmt | 7 | 0 | 0 | 0.02s |
✅ COPYPASTE | jscpd | yes | no | 2.74s | |
✅ DOCKERFILE | hadolint | 103 | 0 | 19.9s | |
✅ JSON | eslint-plugin-jsonc | 20 | 0 | 0 | 2.46s |
✅ JSON | jsonlint | 18 | 0 | 0.25s | |
✅ JSON | v8r | 20 | 0 | 12.14s | |
markdownlint | 281 | 0 | 5 | 5.11s | |
✅ MARKDOWN | markdown-link-check | 281 | 0 | 6.12s | |
✅ MARKDOWN | markdown-table-formatter | 281 | 0 | 0 | 7.62s |
✅ OPENAPI | spectral | 1 | 0 | 0.94s | |
bandit | 165 | 51 | 2.48s | ||
✅ PYTHON | black | 165 | 0 | 0 | 3.42s |
✅ PYTHON | flake8 | 165 | 0 | 2.21s | |
✅ PYTHON | isort | 165 | 0 | 0 | 0.36s |
✅ PYTHON | mypy | 165 | 0 | 113.54s | |
✅ PYTHON | pylint | 165 | 0 | 19.74s | |
✅ REPOSITORY | checkov | yes | no | 16.5s | |
✅ REPOSITORY | git_diff | yes | no | 0.02s | |
✅ REPOSITORY | secretlint | yes | no | 13.37s | |
✅ REPOSITORY | trivy | yes | no | 24.42s | |
✅ SPELL | cspell | 661 | 0 | 21.25s | |
✅ SPELL | misspell | 491 | 0 | 0 | 0.48s |
✅ XML | xmllint | 3 | 0 | 0.0s | |
✅ YAML | prettier | 79 | 0 | 0 | 2.21s |
✅ YAML | v8r | 22 | 0 | 29.12s | |
✅ YAML | yamllint | 80 | 0 | 1.25s |
See errors details in artifact MegaLinter reports on CI Job page
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ API | spectral | 2 | 0 | 3.04s | |
✅ BASH | bash-exec | 5 | 0 | 0.07s | |
✅ BASH | shellcheck | 5 | 0 | 0.14s | |
✅ BASH | shfmt | 5 | 0 | 0 | 0.65s |
✅ COPYPASTE | jscpd | yes | no | 3.83s | |
✅ DOCKERFILE | hadolint | 130 | 0 | 16.79s | |
✅ JSON | jsonlint | 18 | 0 | 0.24s | |
✅ JSON | v8r | 20 | 0 | 30.61s | |
markdownlint | 265 | 0 | 272 | 38.29s | |
✅ MARKDOWN | markdown-table-formatter | 265 | 0 | 0 | 141.09s |
✅ OPENAPI | spectral | 2 | 0 | 3.26s | |
bandit | 211 | 64 | 3.64s | ||
✅ PYTHON | black | 211 | 0 | 0 | 5.75s |
✅ PYTHON | flake8 | 211 | 0 | 1.75s | |
✅ PYTHON | isort | 211 | 0 | 0 | 1.32s |
✅ PYTHON | mypy | 211 | 0 | 19.46s | |
✅ PYTHON | pylint | 211 | 0 | 17.05s | |
✅ PYTHON | ruff | 211 | 0 | 0 | 0.75s |
✅ REPOSITORY | checkov | yes | no | 43.37s | |
✅ REPOSITORY | git_diff | yes | no | 0.68s | |
grype | yes | 1 | 25.71s | ||
✅ REPOSITORY | secretlint | yes | no | 18.24s | |
✅ REPOSITORY | trivy | yes | no | 20.91s | |
✅ REPOSITORY | trivy-sbom | yes | no | 5.95s | |
trufflehog | yes | 1 | 12.35s | ||
✅ SPELL | cspell | 693 | 0 | 30.37s | |
lychee | 346 | 1 | 12.44s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0.68s |
✅ YAML | prettier | 161 | 0 | 0 | 6.2s |
✅ YAML | v8r | 102 | 0 | 195.56s | |
✅ YAML | yamllint | 162 | 0 | 2.56s |
See detailed report in MegaLinter reports
- "--strict" | ||
cli_lint_fix_arg_name: "--fix" | ||
cli_lint_fix_remove_args: | ||
- "lint" | ||
cli_docker_image: norionomura/swiftlint | ||
cli_docker_args: | ||
- "-v" | ||
- "{{WORKSPACE}}:/tmp/lint:rw" | ||
- "$(pwd):$(pwd)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to change the /tmp/lint
. Just update the working directory to point to /tmp/lint
.
Example:
docker run --rm -v /github/workspace:/tmp/lint -w /tmp/lint ghcr.io/realm/swiftlint:latest swiftlint --strict
@@ -19,16 +19,16 @@ linters: | |||
cli_lint_extra_args: | |||
- "lint" | |||
cli_lint_extra_args_after: | |||
- "--path" | |||
- "/tmp/lint" | |||
- "--strict" | |||
cli_lint_fix_arg_name: "--fix" | |||
cli_lint_fix_remove_args: | |||
- "lint" | |||
cli_docker_image: norionomura/swiftlint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use realm swiftlint's Docker image instead?
@@ -19,16 +19,16 @@ linters: | |||
cli_lint_extra_args: | |||
- "lint" | |||
cli_lint_extra_args_after: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also update the examples
in line 38?
@Noraldeno since it is a branch from this repo, if you know a bit about swift and would want to finish it off, you can either open a new PR that targets this branch, or a PR based on this one that targets main. Last time I updated it, it still didn't work, now there's a bit of conflicts (expected, most of the repo is generated files) We'd love the help, it's with small contributions that we keep up with every programming environment ;) |
Yes. I'll go ahead and open a new PR. |
Fixes #440