Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiftlint error that is unable to find lintable swift files #4427

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Noraldeno
Copy link
Contributor

@Noraldeno Noraldeno commented Dec 24, 2024

Fixes #440

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix
Copy link
Collaborator

echoix commented Dec 24, 2024

Great work!
@nvuillam Do you want to take a look? The test cases pass, but not the Megalinter part.

@Noraldeno
Copy link
Contributor Author

@echoix Thx! Happy to help!

Looks like the linting error is the spell check. How do you usually handle spelling errors like this?

CHANGELOG.md:24:104    - Unknown word (lintable)   -- linter is unable to find lintable files. Fixes [#440]
	 Suggestions: [linable, liftable, lineable, linkable, listable]

@echoix
Copy link
Collaborator

echoix commented Dec 24, 2024

@echoix Thx! Happy to help!

Looks like the linting error is the spell check. How do you usually handle spelling errors like this?


CHANGELOG.md:24:104    - Unknown word (lintable)   -- linter is unable to find lintable files. Fixes [#440]

	 Suggestions: [linable, liftable, lineable, linkable, listable]

If it's not a typo, add them to the cspell exclusion (dict)

You can download the artifact and use the pre-populated changed file in report, removing the unnecessary changes if there's some typos to fix: https://github.com/oxsecurity/megalinter/actions/runs/12477772394

image

- Update swiftlint documentation

- Update to use swiftlint's Docker image

- Add "lintable" to cspell exclusion

Fixes oxsecurity#440
@Noraldeno Noraldeno force-pushed the fixes/swiftlint-path branch from 6b2a6d7 to 7891815 Compare December 24, 2024 22:10
@Noraldeno
Copy link
Contributor Author

@echoix Thx! Happy to help!
Looks like the linting error is the spell check. How do you usually handle spelling errors like this?


CHANGELOG.md:24:104    - Unknown word (lintable)   -- linter is unable to find lintable files. Fixes [#440]

	 Suggestions: [linable, liftable, lineable, linkable, listable]

If it's not a typo, add them to the cspell exclusion (dict)

You can download the artifact and use the pre-populated changed file in report, removing the unnecessary changes if there's some typos to fix: https://github.com/oxsecurity/megalinter/actions/runs/12477772394

image

I added the word "lintable" to cspell exclusion

@echoix echoix merged commit 54384dd into oxsecurity:main Dec 25, 2024
6 checks passed
@echoix
Copy link
Collaborator

echoix commented Dec 25, 2024

Should #1757 be closed now?

@Noraldeno Noraldeno deleted the fixes/swiftlint-path branch December 25, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting swift code does not work. Error: No lintable files found at paths: '/tmp/lint'
2 participants