Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My solution #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

My solution #67

wants to merge 2 commits into from

Conversation

erikthiem
Copy link

mikegee
mikegee reviewed May 30, 2017
View reviewed changes
spec/refresher_spec.rb
end

it "Yes, it is a Object, but which" do
expect(1.is_a? _fill_in_object_).to be true
expect(1.is_a? Fixnum).to be true
Copy link
Member

@mikegee mikegee May 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 2.4 removes the Fixnum (and Bignum) classes. Replacing Fixnum with Integer here works on 2.4 and all previous versions since Fixnum and Bignum were subclasses of Integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegee mikegee mikegee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikthiem @mikegee