Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jack Chester Solutions #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Jack Chester Solutions #69

wants to merge 1 commit into from
+18 −18

Conversation

jack-chester
Copy link

@jack-chester jack-chester commented Jun 5, 2017 •
edited
Loading

@jaybobo @matt529

mikegee
mikegee reviewed Jun 16, 2017
View reviewed changes
spec/refresher_spec.rb
expect(a_hash.empty?).to be true
end
end

context "on loops, yeah!!!" do
it "should loop over the array and return a new array" do
loopy = [1,2,3]
expect(loopy._fill_in_method_here_ { |n| n + 1 }).to eq [2,3,4]
expect(loopy.collect { |n| n + 1 }).to eq [2,3,4]
Copy link
Member

@mikegee mikegee Jun 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map is typically preferred over collect. (They are aliases.)

@mikegee
Copy link
Member

mikegee commented Jun 16, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegee mikegee mikegee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-chester @mikegee