Update the-build to use headless chrome #212
Conversation
| @@ -142,11 +142,15 @@ | |||
| <!-- The one that's available is the location we're moving from. --> | |||
| <available file="${build.dir}/web/core" type="dir" property="drupal.root.old" value="web" /> | |||
| <available file="${build.dir}/docroot/core" type="dir" property="drupal.root.old" value="docroot" /> | |||
| <available file="${build.dir}/${drupal.root.old}/sites/default/settings.ddev.php" type="file" property="ddev_settings_exists" value="true" /> | |||
| <available file="${build.dir}/${drupal.root}/sites/default/settings.ddev.php" type="file" property="ddev_settings_exists" value="true" /> | |||
There was a problem hiding this comment.
@byrond What's up with these unrelated changes?
There was a problem hiding this comment.
@byrond What's up with these unrelated changes?
@agentrickard see description:
Fixes an issue where The Build will not install properly when DDEV is not in use (on CircleCI, for example). The existence of settings.ddev.php is now checked before attempting to copy it. (See targets/install.xml)
This was causing a build failure on palantirnet/drupal-skeleton#141:
https://app.circleci.com/pipelines/github/palantirnet/drupal-skeleton/183/workflows/531485e2-2665-466c-b422-8a9cd5219680/jobs/604
There was a problem hiding this comment.
In hindsight, I could have created a separate PR for that change, but it was blocking this one, so I opted to fix it here.
behat.ymlto work with Headless Chrome. This is being worked on and tested with Test js behat drupal-skeleton#141settings.ddev.phpis now checked before attempting to copy it. (Seetargets/install.xml)Behat\MinkExtensiontoDrupal\MinkExtension, which is the proper configuration according to their documentation. This is mostly relevant when using the "wait for AJAX to finish" step. See https://github.com/jhedstrom/drupalextension/blob/93bf8cd/src/Drupal/DrupalExtension/Context/MinkContext.php#L159 and Use Drupal\MinkExtension instead of Behat default pantheon-systems/example-drops-8-composer#400