-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testers for session lifetime #238
base: development
Are you sure you want to change the base?
Conversation
Is your DynamoDB problem maybe related to this? #240 |
I think it is the same issue and we need add filter by expectation time and not relay only on ttl index |
I've added a fix for that issue to this PR - #237 |
ok great I will merge #237 first |
I will pull development to my branch |
… testers # Conflicts: # tests/test_dynamodb.py
@Lxstr |
I think you should update the target branch to development for this PR |
Changed now |
Hi @idoshr thanks for your continued work. Could you please remove the code changed in commit 4fb799 as we do have need for this should_set_storage method? Also, can you separate the code you added for regeneration into a new PR? This is out of scope, better to just focus on testing for one PR I think |
Add some testers for:
seems like there is some issues with the lifetime session in:
EDIT:
prevent session hijacking by generate session already exists