Base Quart on Flask #261
Closed
Base Quart on Flask #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Quart has Flask as a dependency it can use the Flask config code instead of its own version that does the same. Note the default prefix is changed to QUART.
This removes code duplication and ensures that Quart has the same logic as Flask. There is a downside in that it utilises Flask types e.g. for Flask and Resposne, but this might be fixable in Flask via the SansIO work.
This reduces code duplication, and ensures Quart matches Flask. It is where possible as any IO or usage of globals prohibit usage.
This removes a lot of code and matches Flask's API exactly, thereby bringing Quart and Flask closer together.
This removes a lot of code and matches Flask's API exactly, thereby bringing Quart and Flask closer together
davidism
reviewed
Aug 19, 2023
There was a problem hiding this comment.
Seems like you could reuse Flask's SessionInterface as well. Am I missing something that prevents that?
There was a problem hiding this comment.
I've not looked into it yet. Will do after this, hopefully, merges (to try and limit the scope).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.