Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ContentRange in the right way. #332

Merged
merged 1 commit into from
May 19, 2024

Conversation

jeffpeng3
Copy link
Contributor

Summary

According to werkzeug's documentation, end is not included in the range, so end should not be reduced by one.

Changes:

Changed end - 1 to end and modified test at the same time.

Issues:

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@pgjones pgjones merged commit ba31554 into pallets:main May 19, 2024
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parameter of ContentRange in quart.wrappers.Response._process_range_request is not correct.
2 participants