Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flask default config for Quartz default config, to pull in missing keys #374

Closed
wants to merge 16 commits into from
Closed

Use flask default config for Quartz default config, to pull in missing keys #374

wants to merge 16 commits into from

Conversation

JamesParrott
Copy link

@JamesParrott
Bump python to 3.9. Drop Python 3.8 trove classifier.
98bf30d
@JamesParrott
Bump minimum Python to 3.9.0 (drop 3.8) in README.rst
ef425e9
@JamesParrott
Describe dropping Python 3.8 in python_versions.rst
a0dc931
@JamesParrott
Merge pull request #1 from JamesParrott/patch-3
ac7168b 
Describe dropping Python 3.8 in python_versions.rst
@JamesParrott
Merge pull request #2 from JamesParrott/patch-2
3653b9e 
Bump minimum Python to 3.9.0 (drop 3.8) in README.rst
@JamesParrott
Merge pull request #3 from JamesParrott/patch-1
dfd2a96 
Bump python to 3.9.  Drop Python 3.8 trove classifier.
@JamesParrott
Remove Python 3.8 tests from CI
2d79991
@JamesParrott
Base Quart.default_config on flask.app.Flask.default_config
74003b3
@JamesParrott
Run Black and isort
229257c
@JamesParrott
Pin hypercorn to <=0.16.0
13a5a2b
@JamesParrott
Fix type annotations and overloads
dd26c09
@JamesParrott
Try to add in all required overloads for Request.get_data (not quite …
a765196 
…managed)
@JamesParrott
We added type hints to yo' type hints (yo dawg...).
9a1baab 
Try to fix:
 mypy: commands[0]> mypy src/quart/ tests/
src/quart/app.py:129: error: Incompatible import of "ParamSpec" (imported name has type "type[typing_extensions.ParamSpec]", local name has type "type[typing.ParamSpec]")  [assignment]
Found 1 error in 1 file (checked 57 source files)
@davidism
Copy link
Member

davidism commented Nov 14, 2024 •
edited
Loading

The changes here don't seem to match the title. Please don't mix multiple changes in one PR, it makes it hard to review. Keep dropping Python 3.8, typing, and bug fixes separate.

@JamesParrott
Copy link
Author

@davidism I appreciate this PR now requires a little more work to understand. But the further changes I made after I first named the PR, thinking the fix would be simple, have enabled the type checking and tests all to pass again for the first time in 6 months.

This was referenced Nov 14, 2024
Closed
Closed
Closed
@pgjones
Copy link
Member

pgjones commented Nov 14, 2024

See #373

@pgjones pgjones closed this Nov 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Instantiate Quart object with Flask==3.1.0
3 participants
@JamesParrott @davidism @pgjones