DEPR: Raise FutureWarning about raising an error in __array__ when copy=False cannot be honored
#60395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KevsterAmp
commented
Nov 22, 2024
•
KevsterAmp
commented
- closes DEPR: deprecate / warn about raising an error in __array__ when copy=False cannot be honore #60340(Replace xxxx with the GitHub issue number)
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
pandas/core/arrays/arrow/array.py
Outdated
Comment on lines
666
to
668
| import warnings | ||
|
|
||
| from pandas.util._exceptions import find_stack_level |
There was a problem hiding this comment.
You can move those warnings to the top of the file
pandas/core/arrays/arrow/array.py
Outdated
| "raise an error when a zero-copy numpy array is not possible", | ||
| FutureWarning, | ||
| stacklevel=find_stack_level(), | ||
| ) | ||
| # TODO: By using `zero_copy_only` it may be possible to implement this | ||
| raise ValueError( |
There was a problem hiding this comment.
This error should then be removed (we are adding the warning instead of the error, to warn people it will error in the future).
There was a problem hiding this comment.
Gotcha, I initially thought we would raise both an error and a warning.
pandas/core/arrays/categorical.py
Outdated
Comment on lines
1675
to
1677
| import warnings | ||
|
|
||
| from pandas.util._exceptions import find_stack_level |
There was a problem hiding this comment.
Same here about the imports (and similar for next cases)
pandas/core/arrays/categorical.py
Outdated
| "raise an error when a zero-copy numpy array is not possible", | ||
| FutureWarning, | ||
| stacklevel=find_stack_level(), | ||
| ) | ||
| raise ValueError( |
There was a problem hiding this comment.
And same for the errors
jorisvandenbossche
added
Compat
|
Thanks for the review despite this PR being in draft. Working on the tests and changes based on the comments, will mark it as ready once done |
…lse-futurewarning
|
Re-marking this as draft since I'll be fixing the errors on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.