-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow submission of Leaders portion of form if a company is marked as "Leaders Eligible" via label #17
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shinsina There are a couple of structural issues to address, but this must be an opt-in configurable option, not a change made across the board. Existing customers have this already deployed with expected functionality, and at least one (AB Media) uses it to add companies to the leaders program, not just update the selections.
The out-of-the-box solution that is supposed to be used for selecting which companies are allowed to see the leadership submission segment is the leadershipCompanyLabel
config.
@solocommand Want to start out in saying I ultimately don't care how we handle this but I want the reasoning/rationale and most importantly the expected behavior provided a specific company criteria to be consistent, my understanding via previous discussions was to "make the form logic and the site logic the same for determining who is or is not a leader" and this would be doing that. The Additionally, I wasn't able to find anyone using Ultimately another additional configuration option to opt into this behavior (showing leaders only to companies that meet |
@solocommand In the current state I've opted to just use the existing label configuration option, this separates the logic of "Leaders Eligible" from "Is a Leader" entirely so as not to cause potential points of conflict or confusion as to who gets what and how between this and the site. |
Portal Homepage NOT LEADER:
Portal Homepage LEADER:
Following submission of Leaders portion if not eligible:
This would only occur if somehow a user navigated to the Leaders portion of their respective Company Update form (which would have to be done via the URL as there isn't a button presented to them to be directed to it) and attempted to submit that portion.